Remove redundant dependency calls
- In the current state, the build system has too many
dependency calls, because of which meson tries to find
the same dependendency mutiple times & prints a trace
on the console.This would have been an ideal solution
when all the subdirectories are subprojects in meson but
in the current context it is not.
- Even though meson uses the cached dependency objects
rather than fetching them every time, it might not
give any added advantage on the performance front.
- But checking for the same dependency mutiple times gives
a false impression to the users & this can be avoided by
re-using the dependency objects across subdirectories.
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: Ic428b2ab1897e4dc4a0024164c07fd416c927da1
diff --git a/meson.build b/meson.build
index 9898884..0c50ba8 100644
--- a/meson.build
+++ b/meson.build
@@ -37,6 +37,11 @@
configuration: conf_data
)
+phosphor_dbus_interfaces = dependency('phosphor-dbus-interfaces')
+sdbusplus = dependency('sdbusplus')
+sdeventplus = dependency('sdeventplus')
+systemd = dependency('systemd')
+
subdir('libpldm')
if get_option('libpldm-only').disabled()
@@ -48,8 +53,8 @@
version: meson.project_version(),
dependencies: [
libpldm,
- dependency('phosphor-dbus-interfaces'),
- dependency('sdbusplus'),
+ phosphor_dbus_interfaces,
+ sdbusplus,
],
install: true,
include_directories: include_directories(libpldmutils_headers),
@@ -65,9 +70,9 @@
libpldmutils,
libpldmresponder,
libpldmutils,
- dependency('sdbusplus'),
- dependency('sdeventplus'),
- dependency('phosphor-dbus-interfaces')
+ sdbusplus,
+ sdeventplus,
+ phosphor_dbus_interfaces
]
executable(