commit 0469b56837cf4c972609832ae00f0441ec76049b
author Ed Tanous <etanous@nvidia.com> Mon Jan 06 12:35:10 2025 -0800
committer ManojKiran Eda <manojkiran.eda@gmail.com> Tue Jan 07 05:27:04 2025 +0000
tree 5c40438b357f62d3152af1a3978344b484cff08a
parent 7c14fc4793a4a5fca7210377c32bd241127e96d5

Replace all isnan calls with isfinite

In most of the numeric sensor code, the code uses isnan as an analog for
"Can be used sanely in a math equation"  Unfortunately, isnan will
return false for things like infinity, negative infinity, large values,
etc that aren't usable in math, but are not nan.

This commit replaces all calls in the codebase from isnan to isfinite[1]

Testing: Need help here from maintainers to understand what they'd like
to see in terms of tests.  This is a pretty isolated and mechanical
change.

[1] https://en.cppreference.com/w/cpp/numeric/math/isfinite

Change-Id: I4995ea319c058869c3f7d010ae8b5a08c68b10e5
Signed-off-by: Ed Tanous <etanous@nvidia.com>

platform-mc/numeric_sensor.cpp

diff --git a/platform-mc/numeric_sensor.cpp b/platform-mc/numeric_sensor.cpp
index 0c40f2c..ee4ccdc 100644
--- a/platform-mc/numeric_sensor.cpp
+++ b/platform-mc/numeric_sensor.cpp
@@ -258,7 +258,7 @@
      * updateTime is in microseconds
      */
     updateTime = static_cast<uint64_t>(DEFAULT_SENSOR_UPDATER_INTERVAL * 1000);
-    if (!std::isnan(pdr->update_interval))
+    if (std::isfinite(pdr->update_interval))
     {
         updateTime = pdr->update_interval * 1000000;
     }
@@ -589,14 +589,24 @@
 double NumericSensor::conversionFormula(double value)
 {
     double convertedValue = value;
-    convertedValue *= std::isnan(resolution) ? 1 : resolution;
-    convertedValue += std::isnan(offset) ? 0 : offset;
+    if (std::isfinite(resolution))
+    {
+        convertedValue *= resolution;
+    }
+    if (std::isfinite(offset))
+    {
+        convertedValue += offset;
+    }
     return convertedValue;
 }
 
 double NumericSensor::unitModifier(double value)
 {
-    return std::isnan(value) ? value : value * std::pow(10, baseUnitModifier);
+    if (!std::isfinite(value))
+    {
+        return value;
+    }
+    return value * std::pow(10, baseUnitModifier);
 }
 
 void NumericSensor::updateReading(bool available, bool functional, double value)
@@ -627,7 +637,7 @@
     {
         newValue = unitModifier(conversionFormula(value));
         if (newValue != curValue &&
-            (!std::isnan(newValue) || !std::isnan(curValue)))
+            (std::isfinite(newValue) || std::isfinite(curValue)))
         {
             if (!useMetricInterface)
             {
@@ -643,7 +653,7 @@
     else
     {
         if (newValue != curValue &&
-            (!std::isnan(newValue) || !std::isnan(curValue)))
+            (std::isfinite(newValue) || std::isfinite(curValue)))
         {
             if (!useMetricInterface)
             {
@@ -727,7 +737,7 @@
         value = metricIntf->value();
     }
     if (thresholdWarningIntf &&
-        !std::isnan(thresholdWarningIntf->warningHigh()))
+        std::isfinite(thresholdWarningIntf->warningHigh()))
     {
         auto threshold = thresholdWarningIntf->warningHigh();
         auto alarm = thresholdWarningIntf->warningAlarmHigh();
@@ -747,7 +757,8 @@
         }
     }
 
-    if (thresholdWarningIntf && !std::isnan(thresholdWarningIntf->warningLow()))
+    if (thresholdWarningIntf &&
+        std::isfinite(thresholdWarningIntf->warningLow()))
     {
         auto threshold = thresholdWarningIntf->warningLow();
         auto alarm = thresholdWarningIntf->warningAlarmLow();
@@ -768,7 +779,7 @@
     }
 
     if (thresholdCriticalIntf &&
-        !std::isnan(thresholdCriticalIntf->criticalHigh()))
+        std::isfinite(thresholdCriticalIntf->criticalHigh()))
     {
         auto threshold = thresholdCriticalIntf->criticalHigh();
         auto alarm = thresholdCriticalIntf->criticalAlarmHigh();
@@ -789,7 +800,7 @@
     }
 
     if (thresholdCriticalIntf &&
-        !std::isnan(thresholdCriticalIntf->criticalLow()))
+        std::isfinite(thresholdCriticalIntf->criticalLow()))
     {
         auto threshold = thresholdCriticalIntf->criticalLow();
         auto alarm = thresholdCriticalIntf->criticalAlarmLow();
@@ -840,7 +851,7 @@
                 return PLDM_ERROR;
             }
             if (direction == pldm::utils::Direction::HIGH &&
-                !std::isnan(thresholdWarningIntf->warningHigh()))
+                std::isfinite(thresholdWarningIntf->warningHigh()))
             {
                 auto alarm = thresholdWarningIntf->warningAlarmHigh();
                 if (alarm == newAlarm)
@@ -858,7 +869,7 @@
                 }
             }
             else if (direction == pldm::utils::Direction::LOW &&
-                     !std::isnan(thresholdWarningIntf->warningLow()))
+                     std::isfinite(thresholdWarningIntf->warningLow()))
             {
                 auto alarm = thresholdWarningIntf->warningAlarmLow();
                 if (alarm == newAlarm)
@@ -887,7 +898,7 @@
                 return PLDM_ERROR;
             }
             if (direction == pldm::utils::Direction::HIGH &&
-                !std::isnan(thresholdCriticalIntf->criticalHigh()))
+                std::isfinite(thresholdCriticalIntf->criticalHigh()))
             {
                 auto alarm = thresholdCriticalIntf->criticalAlarmHigh();
                 if (alarm == newAlarm)
@@ -905,7 +916,7 @@
                 }
             }
             else if (direction == pldm::utils::Direction::LOW &&
-                     !std::isnan(thresholdCriticalIntf->criticalLow()))
+                     std::isfinite(thresholdCriticalIntf->criticalLow()))
             {
                 auto alarm = thresholdCriticalIntf->criticalAlarmLow();
                 if (alarm == newAlarm)