commit 07a07e2ac4cb41e18c4c787f6e8015d89c1f1371
author Manojkiran Eda <manojkiran.eda@gmail.com> Wed Apr 24 19:15:10 2024 +0530
committer ManojKiran Eda <manojkiran.eda@gmail.com> Thu Apr 25 05:02:11 2024 +0000
tree d64a70b1601ff09e907bef0554270c99dd638157
parent ac0da58c44e6ac210715071e9d3f80dce28010b6

Fix a potential crash due to unbound array access

It was reported that, there is an inaccurate check in host_pdr_handler
code that could lead to an unbound access of an array resulting in pldm
crash. This commit aims at fixing it.

Resolves openbmc/pldm/#36

Change-Id: I1bba25f5b1cad55a30ce956f83b8c15b93149219
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

host-bmc/host_pdr_handler.cpp

diff --git a/host-bmc/host_pdr_handler.cpp b/host-bmc/host_pdr_handler.cpp
index 72f2478..ea55262 100644
--- a/host-bmc/host_pdr_handler.cpp
+++ b/host-bmc/host_pdr_handler.cpp
@@ -880,7 +880,8 @@
                             }
                         }
 
-                        if (sensorOffset > compositeSensorStates.size())
+                        if ((compositeSensorStates.size() > 1) &&
+                            (sensorOffset > (compositeSensorStates.size() - 1)))
                         {
                             error("Error Invalid data, Invalid sensor offset");
                             return;