commit 0a725f83d2fe4709502d13a8af00736ff85a001f
author Manojkiran Eda <manojkiran.eda@gmail.com> Sat Oct 23 06:02:26 2021 +0530
committer Manojkiran Eda <manojkiran.eda@gmail.com> Tue Nov 23 10:03:09 2021 +0530
tree f11851da27666a645df07068263b57b35ec22f3c
parent 66d26e36aa421d4695a3dba3dd9348da8d790304

Fix a bad error traces

There are couple of places where we are trying to print
the 8 bit value, and it std::cout cannot display those directly,
we need to typecast it to an integer.

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: Ibaa212de28e125fd6904c0a7b1f5b5f8c0609d51

libpldmresponder/base.cpp

diff --git a/libpldmresponder/base.cpp b/libpldmresponder/base.cpp
index dcb6fd6..572f8f1 100644
--- a/libpldmresponder/base.cpp
+++ b/libpldmresponder/base.cpp
@@ -217,7 +217,7 @@
         if (rc || completionCode)
         {
             std::cerr << "Failed to decode setEventReceiver command response,"
-                      << " rc=" << rc << "cc=" << (uint8_t)completionCode
+                      << " rc=" << rc << "cc=" << (unsigned)completionCode
                       << "\n";
             pldm::utils::reportError(
                 "xyz.openbmc_project.bmc.pldm.InternalFailure");

pldmtool/pldm_cmd_helper.cpp

diff --git a/pldmtool/pldm_cmd_helper.cpp b/pldmtool/pldm_cmd_helper.cpp
index 92979c0..f58894f 100644
--- a/pldmtool/pldm_cmd_helper.cpp
+++ b/pldmtool/pldm_cmd_helper.cpp
@@ -151,8 +151,8 @@
     }
     catch (const std::exception& e)
     {
-        std::cerr << "GetInstanceId D-Bus call failed, MCTP id = " << mctp_eid
-                  << ", error = " << e.what() << "\n";
+        std::cerr << "GetInstanceId D-Bus call failed, MCTP id = "
+                  << (unsigned)mctp_eid << ", error = " << e.what() << "\n";
         return;
     }
     auto [rc, requestMsg] = createRequestMsg();