commit 165749d1494ce9e2e9e4b69b9e9d66a7a7dd7751
author Pavithra Barithaya <pavithra.b@ibm.com> Mon Jul 10 01:05:26 2023 -0500
committer Pavithra Barithaya <pavithra.b@ibm.com> Wed Jul 19 04:39:48 2023 +0000
tree fd70c05dc312b8d64fb4cfc16974eecaf857fdaf
parent a7dbca530d70fbb8e2a4ed56611d9f16dc582827

clang-error: fix clang-diagnostic-inconsistent-missing-override error

This clang-error is generated when a function overrides a member
function but is not marked 'override'.

Change-Id: I664941c2dff5be93dec1571cc974fae2168925f2
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>

libpldmresponder/bios_enum_attribute.hpp

diff --git a/libpldmresponder/bios_enum_attribute.hpp b/libpldmresponder/bios_enum_attribute.hpp
index a798804..b175cc4 100644
--- a/libpldmresponder/bios_enum_attribute.hpp
+++ b/libpldmresponder/bios_enum_attribute.hpp
@@ -65,7 +65,7 @@
         Table& attrValueEntry) override;
 
     int updateAttrVal(Table& newValue, uint16_t attrHdl, uint8_t attrType,
-                      const pldm::utils::PropertyValue& newPropVal);
+                      const pldm::utils::PropertyValue& newPropVal) override;
 
   private:
     std::vector<std::string> possibleValues;

libpldmresponder/bios_integer_attribute.hpp

diff --git a/libpldmresponder/bios_integer_attribute.hpp b/libpldmresponder/bios_integer_attribute.hpp
index 5d342c6..114b24a 100644
--- a/libpldmresponder/bios_integer_attribute.hpp
+++ b/libpldmresponder/bios_integer_attribute.hpp
@@ -61,7 +61,7 @@
         Table& attrValueEntry) override;
 
     int updateAttrVal(Table& newValue, uint16_t attrHdl, uint8_t attrType,
-                      const pldm::utils::PropertyValue& newPropVal);
+                      const pldm::utils::PropertyValue& newPropVal) override;
 
   private:
     /** @brief Integer field from json */

libpldmresponder/bios_string_attribute.hpp

diff --git a/libpldmresponder/bios_string_attribute.hpp b/libpldmresponder/bios_string_attribute.hpp
index 5132841..33726d5 100644
--- a/libpldmresponder/bios_string_attribute.hpp
+++ b/libpldmresponder/bios_string_attribute.hpp
@@ -84,7 +84,7 @@
         Table& attrValueEntry) override;
 
     int updateAttrVal(Table& newValue, uint16_t attrHdl, uint8_t attrType,
-                      const pldm::utils::PropertyValue& newPropVal);
+                      const pldm::utils::PropertyValue& newPropVal) override;
 
   private:
     /** @brief string field from json */

libpldmresponder/test/libpldmresponder_bios_attribute_test.cpp

diff --git a/libpldmresponder/test/libpldmresponder_bios_attribute_test.cpp b/libpldmresponder/test/libpldmresponder_bios_attribute_test.cpp
index 305e7be..93b633a 100644
--- a/libpldmresponder/test/libpldmresponder_bios_attribute_test.cpp
+++ b/libpldmresponder/test/libpldmresponder_bios_attribute_test.cpp
@@ -38,7 +38,7 @@
 
     void generateAttributeEntry(
         const std::variant<int64_t, std::string>& /*attributevalue*/,
-        Table& /*attrValueEntry*/)
+        Table& /*attrValueEntry*/) override
     {}
 };
 

pldmtool/oem/ibm/pldm_oem_ibm.cpp

diff --git a/pldmtool/oem/ibm/pldm_oem_ibm.cpp b/pldmtool/oem/ibm/pldm_oem_ibm.cpp
index 100857e..db2b63a 100644
--- a/pldmtool/oem/ibm/pldm_oem_ibm.cpp
+++ b/pldmtool/oem/ibm/pldm_oem_ibm.cpp
@@ -109,7 +109,7 @@
     }
 
     void parseResponseMsg(pldm_msg*, size_t) override {}
-    void exec()
+    void exec() override
     {
         std::vector<uint8_t> requestMsg(sizeof(pldm_msg_hdr) +
                                         PLDM_GET_FILE_TABLE_REQ_BYTES);