pldm: Remove unnecessary type casting in logs
This commit removes the unnecessary type casting of values of the
journal logs based on supported types mentioned in LG2 documentation
[1].
Testing: Verified the debug traces to correct.
'''
For Instance:
Earlier -
error(”TYPE = {TYPE} “, “TYPE”, static_cast<unsigned>(PLDM_STATE_EFFECTER_PDR));
Journal trace -
May 27 08:16:51 p10bmc pldmd[931]: TYPE = 11
After Correction -
error(”TYPE = {TYPE}“, “TYPE”, PLDM_STATE_EFFECTER_PDR);
Journal trace -
May 27 08:16:51 p10bmc pldmd[931]: TYPE = Enum(11)
'''
[1]: https://github.com/openbmc/phosphor-logging/blob/master/docs/structured-logging.md#lg2
Change-Id: Ia649ecd4ecbb73c421f7844885f58a6835805719
Signed-off-by: Riya Dixit <riyadixitagra@gmail.com>
diff --git a/fw-update/inventory_manager.cpp b/fw-update/inventory_manager.cpp
index b8f86ea..f341f28 100644
--- a/fw-update/inventory_manager.cpp
+++ b/fw-update/inventory_manager.cpp
@@ -30,7 +30,7 @@
instanceIdDb.free(eid, instanceId);
error(
"Failed to encode query device identifiers req for endpoint ID '{EID}', response code '{RC}'",
- "EID", unsigned(eid), "RC", rc);
+ "EID", eid, "RC", rc);
continue;
}
@@ -43,7 +43,7 @@
{
error(
"Failed to send query device identifiers request for endpoint ID '{EID}', response code '{RC}'",
- "EID", unsigned(eid), "RC", rc);
+ "EID", eid, "RC", rc);
}
}
}
@@ -56,7 +56,7 @@
{
error(
"No response received for query device identifiers for endpoint ID '{EID}'",
- "EID", unsigned(eid));
+ "EID", eid);
return;
}
@@ -72,8 +72,7 @@
{
error(
"Failed to decode query device identifiers response for endpoint ID '{EID}' and descriptor count '{DESCRIPTOR_COUNT}', response code '{RC}'",
- "EID", unsigned(eid), "DESCRIPTOR_COUNT", descriptorCount, "RC",
- rc);
+ "EID", eid, "DESCRIPTOR_COUNT", descriptorCount, "RC", rc);
return;
}
@@ -81,7 +80,7 @@
{
error(
"Failed to query device identifiers response for endpoint ID '{EID}', completion code '{CC}'",
- "EID", unsigned(eid), "CC", unsigned(completionCode));
+ "EID", eid, "CC", completionCode);
return;
}
@@ -99,7 +98,7 @@
error(
"Failed to decode descriptor type {TYPE}, length {LENGTH} and value for endpoint ID '{EID}', response code '{RC}'",
"TYPE", descriptorType, "LENGTH", deviceIdentifiersLen, "EID",
- unsigned(eid), "RC", rc);
+ eid, "RC", rc);
return;
}
@@ -123,7 +122,7 @@
{
error(
"Failed to decode vendor-defined descriptor value for endpoint ID '{EID}', response code '{RC}'",
- "EID", unsigned(eid), "RC", rc);
+ "EID", eid, "RC", rc);
return;
}
@@ -164,7 +163,7 @@
instanceIdDb.free(eid, instanceId);
error(
"Failed to encode get firmware parameters req for endpoint ID '{EID}', response code '{RC}'",
- "EID", unsigned(eid), "RC", rc);
+ "EID", eid, "RC", rc);
return;
}
@@ -177,7 +176,7 @@
{
error(
"Failed to send get firmware parameters request for endpoint ID '{EID}', response code '{RC}'",
- "EID", unsigned(eid), "RC", rc);
+ "EID", eid, "RC", rc);
}
}
@@ -189,7 +188,7 @@
{
error(
"No response received for get firmware parameters for endpoint ID '{EID}'",
- "EID", unsigned(eid));
+ "EID", eid);
descriptorMap.erase(eid);
return;
}
@@ -206,15 +205,16 @@
{
error(
"Failed to decode get firmware parameters response for endpoint ID '{EID}', response code '{RC}'",
- "EID", unsigned(eid), "RC", rc);
+ "EID", eid, "RC", rc);
return;
}
if (fwParams.completion_code)
{
+ auto fw_param_cc = fwParams.completion_code;
error(
"Failed to get firmware parameters response for endpoint ID '{EID}', completion code '{CC}'",
- "EID", unsigned(eid), "CC", unsigned(fwParams.completion_code));
+ "EID", eid, "CC", fw_param_cc);
return;
}
@@ -234,7 +234,7 @@
{
error(
"Failed to decode component parameter table entry for endpoint ID '{EID}', response code '{RC}'",
- "EID", unsigned(eid), "RC", rc);
+ "EID", eid, "RC", rc);
return;
}