pldm: Remove unnecessary type casting in logs
This commit removes the unnecessary type casting of values of the
journal logs based on supported types mentioned in LG2 documentation
[1].
Testing: Verified the debug traces to correct.
'''
For Instance:
Earlier -
error(”TYPE = {TYPE} “, “TYPE”, static_cast<unsigned>(PLDM_STATE_EFFECTER_PDR));
Journal trace -
May 27 08:16:51 p10bmc pldmd[931]: TYPE = 11
After Correction -
error(”TYPE = {TYPE}“, “TYPE”, PLDM_STATE_EFFECTER_PDR);
Journal trace -
May 27 08:16:51 p10bmc pldmd[931]: TYPE = Enum(11)
'''
[1]: https://github.com/openbmc/phosphor-logging/blob/master/docs/structured-logging.md#lg2
Change-Id: Ia649ecd4ecbb73c421f7844885f58a6835805719
Signed-off-by: Riya Dixit <riyadixitagra@gmail.com>
diff --git a/utilities/requester/set_state_effecter.cpp b/utilities/requester/set_state_effecter.cpp
index 19ffd7a..3287c4b 100644
--- a/utilities/requester/set_state_effecter.cpp
+++ b/utilities/requester/set_state_effecter.cpp
@@ -56,7 +56,7 @@
pldm_msg* response = reinterpret_cast<pldm_msg*>(responseMsg);
info(
"Done! Got the response for PLDM send receive message request, response code '{RC}'",
- "RC", lg2::hex, static_cast<uint16_t>(response->payload[0]));
+ "RC", lg2::hex, response->payload[0]);
free(responseMsg);
return 0;
diff --git a/utilities/requester/set_state_effecter_async.cpp b/utilities/requester/set_state_effecter_async.cpp
index 0116deb..f11f5e4 100644
--- a/utilities/requester/set_state_effecter_async.cpp
+++ b/utilities/requester/set_state_effecter_async.cpp
@@ -77,7 +77,7 @@
io.set_enabled(Enabled::Off);
info(
"Done! Got the response for PLDM request message, response code '{RC}'",
- "RC", lg2::hex, static_cast<uint16_t>(response->payload[0]));
+ "RC", lg2::hex, response->payload[0]);
free(responseMsg);
exit(EXIT_SUCCESS);
};