commit 2550cee067c1a4c0d9c594700040be1b1da1c721
author crgeddes <crgeddes@us.ibm.com> Tue May 05 17:51:28 2020 +0000
committer crgeddes <crgeddes@us.ibm.com> Wed May 06 19:27:23 2020 +0000
tree 6ff7acd6dda81f4ccb7379d459f9870c7fbd10e8
parent 6b1d1ca47a7e8cfe16e2b1b8a8dad51a30975d14

Update GTEST EXPECT_EQ macros so they compile with latest gcc

Ubuntu 18.04's latest c++ has gcc 7.5 which was failing w/ signed
vs unsigned comparison in the EXPECT_EQ test cases. This commit
addresses this problem by adding the 'u' to literals that should
be treated by the compiler as unsigned values.

Signed-off-by: crgeddes <crgeddes@us.ibm.com>
Change-Id: I62b93fe0191dd592ec8bb81b9ca09de8b68fa185

libpldm/tests/libpldm_bios_table_test.cpp

diff --git a/libpldm/tests/libpldm_bios_table_test.cpp b/libpldm/tests/libpldm_bios_table_test.cpp
index 93477de..aeb1ac3 100644
--- a/libpldm/tests/libpldm_bios_table_test.cpp
+++ b/libpldm/tests/libpldm_bios_table_test.cpp
@@ -410,10 +410,10 @@
         integerEntry.data());
     pldm_bios_table_attr_entry_integer_decode(entry, &lower, &upper, &scalar,
                                               &def);
-    EXPECT_EQ(lower, 1);
-    EXPECT_EQ(upper, 10);
-    EXPECT_EQ(scalar, 2);
-    EXPECT_EQ(def, 3);
+    EXPECT_EQ(lower, 1u);
+    EXPECT_EQ(upper, 10u);
+    EXPECT_EQ(scalar, 2u);
+    EXPECT_EQ(def, 3u);
 }
 
 TEST(AttrTable, ItearatorTest)
@@ -745,7 +745,7 @@
     auto entry = reinterpret_cast<struct pldm_bios_attr_val_table_entry*>(
         integerEntry.data());
     auto cv = pldm_bios_table_attr_value_entry_integer_decode_cv(entry);
-    EXPECT_EQ(cv, 10);
+    EXPECT_EQ(cv, 10u);
 }
 
 TEST(AttrValTable, IteratorTest)
@@ -1101,11 +1101,11 @@
 
 TEST(PadAndChecksum, PadAndChecksum)
 {
-    EXPECT_EQ(4, pldm_bios_table_pad_checksum_size(0));
-    EXPECT_EQ(7, pldm_bios_table_pad_checksum_size(1));
-    EXPECT_EQ(6, pldm_bios_table_pad_checksum_size(2));
-    EXPECT_EQ(5, pldm_bios_table_pad_checksum_size(3));
-    EXPECT_EQ(4, pldm_bios_table_pad_checksum_size(4));
+    EXPECT_EQ(4u, pldm_bios_table_pad_checksum_size(0));
+    EXPECT_EQ(7u, pldm_bios_table_pad_checksum_size(1));
+    EXPECT_EQ(6u, pldm_bios_table_pad_checksum_size(2));
+    EXPECT_EQ(5u, pldm_bios_table_pad_checksum_size(3));
+    EXPECT_EQ(4u, pldm_bios_table_pad_checksum_size(4));
 
     // The table is borrowed from
     // https://github.com/openbmc/pldm/commit/69d3e7fb2d9935773f4fbf44326c33f3fc0a3c38