pdr: dimm identify leds sensor/effecter support
This commit contains the addition of sensor/effecter pdrs for
dimm identify leds. Also updated the entity instance numbers
for enclosure identify and enclosure fault leds.
Testing Result:
SENSOR(dimm0):
pldmtool platform GetPDR -d 43
{
"nextRecordHandle": 44,
"responseCount": 27,
"recordHandle": 43,
"PDRHeaderVersion": 1,
"PDRType": "State Sensor PDR",
"recordChangeNumber": 0,
"dataLength": 17,
"PLDMTerminusHandle": 0,
"sensorID": 24,
"entityType": "142(OEM)",
"entityInstanceNumber": 1,
"containerID": 3,
"sensorInit": "noInit",
"sensorAuxiliaryNamesPDR": false,
"compositeSensorCount": 1,
"stateSetID[0]": "17",
"possibleStatesSize[0]": 1,
"possibleStates[0]": " 1 2"
}
Set On:
busctl set-property xyz.openbmc_project.LED.GroupManager
/xyz/openbmc_project/led/groups/ddimm0_identify
xyz.openbmc_project.Led.Group Asserted b true
pldmtool raw --data 0x80 0x02 0x21 0x18 0x00 0x01 0x00
Request Message:
08 01 80 02 21 18 00 01 00
Response Message:
08 01 00 02 21 00 01 00 01 00 02
Set Off:
busctl set-property xyz.openbmc_project.LED.GroupManager
/xyz/openbmc_project/led/groups/ddimm0_identify
xyz.openbmc_project.Led.Group Asserted b false
pldmtool raw --data 0x80 0x02 0x21 0x18 0x00 0x01 0x00
Request Message:
08 01 80 02 21 18 00 01 00
Response Message:
08 01 00 02 21 00 01 00 01 00 01
EFFECTER(dimm31):
pldmtool platform GetPDR -d 181
{
"nextRecordHandle": 182,
"responseCount": 29,
"recordHandle": 181,
"PDRHeaderVersion": 1,
"PDRType": "State Effecter PDR",
"recordChangeNumber": 0,
"dataLength": 19,
"PLDMTerminusHandle": 1,
"effecterID": 53,
"entityType": "142(OEM)",
"entityInstanceNumber": 26,
"containerID": 3,
"effecterSemanticID": 0,
"effecterInit": "noInit",
"effecterDescriptionPDR": false,
"compositeEffecterCount": 1,
"stateSetID[0]": "17",
"possibleStatesSize[0]": 1,
"possibleStates[0]": " 1 2"
}
Set On:
pldmtool platform SetStateEffecterStates -i 53 -c 1 -d 1 2
{
"Response": "SUCCESS"
}
busctl get-property xyz.openbmc_project.LED.GroupManager
/xyz/openbmc_project/led/groups/ddimm31_identify
xyz.openbmc_project.Led.Group Asserted
b true
Set Off:
pldmtool platform SetStateEffecterStates -i 53 -c 1 -d 1 1
{
"Response": "SUCCESS"
}
busctl get-property xyz.openbmc_project.LED.GroupManager
/xyz/openbmc_project/led/groups/ddimm31_identify
xyz.openbmc_project.Led.Group Asserted
b false
Signed-off-by: Jayashankar Padath <jayashankar.padath@in.ibm.com>
Change-Id: I2549eb2f8409755f5821dbdd91e75e86e40d34e8
diff --git a/configurations/pdr/4.json b/configurations/pdr/4.json
index ca9f960..a451d2e 100644
--- a/configurations/pdr/4.json
+++ b/configurations/pdr/4.json
@@ -61,7 +61,7 @@
},
{
"type" : 45,
- "instance" : 0,
+ "instance" : 1,
"container" : 0,
"sensors" : [{
"set" : {
@@ -75,8 +75,8 @@
"property_name": "State",
"property_type": "string",
"property_values": [
- "xyz.openbmc_project.Led.Physical.Action.On || xyz.openbmc_project.Led.Physical.Action.Blink",
- "xyz.openbmc_project.Led.Physical.Action.Off"
+ "xyz.openbmc_project.Led.Physical.Action.Off",
+ "xyz.openbmc_project.Led.Physical.Action.On || xyz.openbmc_project.Led.Physical.Action.Blink"
]
}
}]
@@ -128,7 +128,7 @@
"interface": "xyz.openbmc_project.Led.Group",
"property_name": "Asserted",
"property_type": "bool",
- "property_values" : [true, false]
+ "property_values" : [false, true]
}
}]
},
@@ -405,6 +405,550 @@
}]
},
{
+ "entity_path" : "/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm0",
+ "sensors" : [{
+ "set" : {
+ "id" : 17,
+ "size" : 1,
+ "states" : [1,2]
+ },
+ "dbus" : {
+ "path": "/xyz/openbmc_project/led/groups/ddimm0_identify",
+ "interface": "xyz.openbmc_project.Led.Group",
+ "property_name": "Asserted",
+ "property_type": "bool",
+ "property_values" : [false, true]
+ }
+ }]
+ },
+ {
+ "entity_path" : "/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm1",
+ "sensors" : [{
+ "set" : {
+ "id" : 17,
+ "size" : 1,
+ "states" : [1,2]
+ },
+ "dbus" : {
+ "path": "/xyz/openbmc_project/led/groups/ddimm1_identify",
+ "interface": "xyz.openbmc_project.Led.Group",
+ "property_name": "Asserted",
+ "property_type": "bool",
+ "property_values" : [false, true]
+ }
+ }]
+ },
+ {
+ "entity_path" : "/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm2",
+ "sensors" : [{
+ "set" : {
+ "id" : 17,
+ "size" : 1,
+ "states" : [1,2]
+ },
+ "dbus" : {
+ "path": "/xyz/openbmc_project/led/groups/ddimm2_identify",
+ "interface": "xyz.openbmc_project.Led.Group",
+ "property_name": "Asserted",
+ "property_type": "bool",
+ "property_values" : [false, true]
+ }
+ }]
+ },
+ {
+ "entity_path" : "/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm3",
+ "sensors" : [{
+ "set" : {
+ "id" : 17,
+ "size" : 1,
+ "states" : [1,2]
+ },
+ "dbus" : {
+ "path": "/xyz/openbmc_project/led/groups/ddimm3_identify",
+ "interface": "xyz.openbmc_project.Led.Group",
+ "property_name": "Asserted",
+ "property_type": "bool",
+ "property_values" : [false, true]
+ }
+ }]
+ },
+ {
+ "entity_path" : "/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm4",
+ "sensors" : [{
+ "set" : {
+ "id" : 17,
+ "size" : 1,
+ "states" : [1,2]
+ },
+ "dbus" : {
+ "path": "/xyz/openbmc_project/led/groups/ddimm4_identify",
+ "interface": "xyz.openbmc_project.Led.Group",
+ "property_name": "Asserted",
+ "property_type": "bool",
+ "property_values" : [false, true]
+ }
+ }]
+ },
+ {
+ "entity_path" : "/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm5",
+ "sensors" : [{
+ "set" : {
+ "id" : 17,
+ "size" : 1,
+ "states" : [1,2]
+ },
+ "dbus" : {
+ "path": "/xyz/openbmc_project/led/groups/ddimm5_identify",
+ "interface": "xyz.openbmc_project.Led.Group",
+ "property_name": "Asserted",
+ "property_type": "bool",
+ "property_values" : [false, true]
+ }
+ }]
+ },
+ {
+ "entity_path" : "/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm6",
+ "sensors" : [{
+ "set" : {
+ "id" : 17,
+ "size" : 1,
+ "states" : [1,2]
+ },
+ "dbus" : {
+ "path": "/xyz/openbmc_project/led/groups/ddimm6_identify",
+ "interface": "xyz.openbmc_project.Led.Group",
+ "property_name": "Asserted",
+ "property_type": "bool",
+ "property_values" : [false, true]
+ }
+ }]
+ },
+ {
+ "entity_path" : "/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm7",
+ "sensors" : [{
+ "set" : {
+ "id" : 17,
+ "size" : 1,
+ "states" : [1,2]
+ },
+ "dbus" : {
+ "path": "/xyz/openbmc_project/led/groups/ddimm7_identify",
+ "interface": "xyz.openbmc_project.Led.Group",
+ "property_name": "Asserted",
+ "property_type": "bool",
+ "property_values" : [false, true]
+ }
+ }]
+ },
+ {
+ "entity_path" : "/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm8",
+ "sensors" : [{
+ "set" : {
+ "id" : 17,
+ "size" : 1,
+ "states" : [1,2]
+ },
+ "dbus" : {
+ "path": "/xyz/openbmc_project/led/groups/ddimm8_identify",
+ "interface": "xyz.openbmc_project.Led.Group",
+ "property_name": "Asserted",
+ "property_type": "bool",
+ "property_values" : [false, true]
+ }
+ }]
+ },
+ {
+ "entity_path" : "/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm9",
+ "sensors" : [{
+ "set" : {
+ "id" : 17,
+ "size" : 1,
+ "states" : [1,2]
+ },
+ "dbus" : {
+ "path": "/xyz/openbmc_project/led/groups/ddimm9_identify",
+ "interface": "xyz.openbmc_project.Led.Group",
+ "property_name": "Asserted",
+ "property_type": "bool",
+ "property_values" : [false, true]
+ }
+ }]
+ },
+ {
+ "entity_path" : "/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm10",
+ "sensors" : [{
+ "set" : {
+ "id" : 17,
+ "size" : 1,
+ "states" : [1,2]
+ },
+ "dbus" : {
+ "path": "/xyz/openbmc_project/led/groups/ddimm10_identify",
+ "interface": "xyz.openbmc_project.Led.Group",
+ "property_name": "Asserted",
+ "property_type": "bool",
+ "property_values" : [false, true]
+ }
+ }]
+ },
+ {
+ "entity_path" : "/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm11",
+ "sensors" : [{
+ "set" : {
+ "id" : 17,
+ "size" : 1,
+ "states" : [1,2]
+ },
+ "dbus" : {
+ "path": "/xyz/openbmc_project/led/groups/ddimm11_identify",
+ "interface": "xyz.openbmc_project.Led.Group",
+ "property_name": "Asserted",
+ "property_type": "bool",
+ "property_values" : [false, true]
+ }
+ }]
+ },
+ {
+ "entity_path" : "/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm12",
+ "sensors" : [{
+ "set" : {
+ "id" : 17,
+ "size" : 1,
+ "states" : [1,2]
+ },
+ "dbus" : {
+ "path": "/xyz/openbmc_project/led/groups/ddimm12_identify",
+ "interface": "xyz.openbmc_project.Led.Group",
+ "property_name": "Asserted",
+ "property_type": "bool",
+ "property_values" : [false, true]
+ }
+ }]
+ },
+ {
+ "entity_path" : "/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm13",
+ "sensors" : [{
+ "set" : {
+ "id" : 17,
+ "size" : 1,
+ "states" : [1,2]
+ },
+ "dbus" : {
+ "path": "/xyz/openbmc_project/led/groups/ddimm13_identify",
+ "interface": "xyz.openbmc_project.Led.Group",
+ "property_name": "Asserted",
+ "property_type": "bool",
+ "property_values" : [false, true]
+ }
+ }]
+ },
+ {
+ "entity_path" : "/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm14",
+ "sensors" : [{
+ "set" : {
+ "id" : 17,
+ "size" : 1,
+ "states" : [1,2]
+ },
+ "dbus" : {
+ "path": "/xyz/openbmc_project/led/groups/ddimm14_identify",
+ "interface": "xyz.openbmc_project.Led.Group",
+ "property_name": "Asserted",
+ "property_type": "bool",
+ "property_values" : [false, true]
+ }
+ }]
+ },
+ {
+ "entity_path" : "/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm15",
+ "sensors" : [{
+ "set" : {
+ "id" : 17,
+ "size" : 1,
+ "states" : [1,2]
+ },
+ "dbus" : {
+ "path": "/xyz/openbmc_project/led/groups/ddimm15_identify",
+ "interface": "xyz.openbmc_project.Led.Group",
+ "property_name": "Asserted",
+ "property_type": "bool",
+ "property_values" : [false, true]
+ }
+ }]
+ },
+ {
+ "entity_path" : "/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm16",
+ "sensors" : [{
+ "set" : {
+ "id" : 17,
+ "size" : 1,
+ "states" : [1,2]
+ },
+ "dbus" : {
+ "path": "/xyz/openbmc_project/led/groups/ddimm16_identify",
+ "interface": "xyz.openbmc_project.Led.Group",
+ "property_name": "Asserted",
+ "property_type": "bool",
+ "property_values" : [false, true]
+ }
+ }]
+ },
+ {
+ "entity_path" : "/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm17",
+ "sensors" : [{
+ "set" : {
+ "id" : 17,
+ "size" : 1,
+ "states" : [1,2]
+ },
+ "dbus" : {
+ "path": "/xyz/openbmc_project/led/groups/ddimm17_identify",
+ "interface": "xyz.openbmc_project.Led.Group",
+ "property_name": "Asserted",
+ "property_type": "bool",
+ "property_values" : [false, true]
+ }
+ }]
+ },
+ {
+ "entity_path" : "/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm18",
+ "sensors" : [{
+ "set" : {
+ "id" : 17,
+ "size" : 1,
+ "states" : [1,2]
+ },
+ "dbus" : {
+ "path": "/xyz/openbmc_project/led/groups/ddimm18_identify",
+ "interface": "xyz.openbmc_project.Led.Group",
+ "property_name": "Asserted",
+ "property_type": "bool",
+ "property_values" : [false, true]
+ }
+ }]
+ },
+ {
+ "entity_path" : "/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm19",
+ "sensors" : [{
+ "set" : {
+ "id" : 17,
+ "size" : 1,
+ "states" : [1,2]
+ },
+ "dbus" : {
+ "path": "/xyz/openbmc_project/led/groups/ddimm19_identify",
+ "interface": "xyz.openbmc_project.Led.Group",
+ "property_name": "Asserted",
+ "property_type": "bool",
+ "property_values" : [false, true]
+ }
+ }]
+ },
+ {
+ "entity_path" : "/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm20",
+ "sensors" : [{
+ "set" : {
+ "id" : 17,
+ "size" : 1,
+ "states" : [1,2]
+ },
+ "dbus" : {
+ "path": "/xyz/openbmc_project/led/groups/ddimm20_identify",
+ "interface": "xyz.openbmc_project.Led.Group",
+ "property_name": "Asserted",
+ "property_type": "bool",
+ "property_values" : [false, true]
+ }
+ }]
+ },
+ {
+ "entity_path" : "/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm21",
+ "sensors" : [{
+ "set" : {
+ "id" : 17,
+ "size" : 1,
+ "states" : [1,2]
+ },
+ "dbus" : {
+ "path": "/xyz/openbmc_project/led/groups/ddimm21_identify",
+ "interface": "xyz.openbmc_project.Led.Group",
+ "property_name": "Asserted",
+ "property_type": "bool",
+ "property_values" : [false, true]
+ }
+ }]
+ },
+ {
+ "entity_path" : "/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm22",
+ "sensors" : [{
+ "set" : {
+ "id" : 17,
+ "size" : 1,
+ "states" : [1,2]
+ },
+ "dbus" : {
+ "path": "/xyz/openbmc_project/led/groups/ddimm22_identify",
+ "interface": "xyz.openbmc_project.Led.Group",
+ "property_name": "Asserted",
+ "property_type": "bool",
+ "property_values" : [false, true]
+ }
+ }]
+ },
+ {
+ "entity_path" : "/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm23",
+ "sensors" : [{
+ "set" : {
+ "id" : 17,
+ "size" : 1,
+ "states" : [1,2]
+ },
+ "dbus" : {
+ "path": "/xyz/openbmc_project/led/groups/ddimm23_identify",
+ "interface": "xyz.openbmc_project.Led.Group",
+ "property_name": "Asserted",
+ "property_type": "bool",
+ "property_values" : [false, true]
+ }
+ }]
+ },
+ {
+ "entity_path" : "/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm24",
+ "sensors" : [{
+ "set" : {
+ "id" : 17,
+ "size" : 1,
+ "states" : [1,2]
+ },
+ "dbus" : {
+ "path": "/xyz/openbmc_project/led/groups/ddimm24_identify",
+ "interface": "xyz.openbmc_project.Led.Group",
+ "property_name": "Asserted",
+ "property_type": "bool",
+ "property_values" : [false, true]
+ }
+ }]
+ },
+ {
+ "entity_path" : "/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm25",
+ "sensors" : [{
+ "set" : {
+ "id" : 17,
+ "size" : 1,
+ "states" : [1,2]
+ },
+ "dbus" : {
+ "path": "/xyz/openbmc_project/led/groups/ddimm25_identify",
+ "interface": "xyz.openbmc_project.Led.Group",
+ "property_name": "Asserted",
+ "property_type": "bool",
+ "property_values" : [false, true]
+ }
+ }]
+ },
+ {
+ "entity_path" : "/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm26",
+ "sensors" : [{
+ "set" : {
+ "id" : 17,
+ "size" : 1,
+ "states" : [1,2]
+ },
+ "dbus" : {
+ "path": "/xyz/openbmc_project/led/groups/ddimm26_identify",
+ "interface": "xyz.openbmc_project.Led.Group",
+ "property_name": "Asserted",
+ "property_type": "bool",
+ "property_values" : [false, true]
+ }
+ }]
+ },
+ {
+ "entity_path" : "/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm27",
+ "sensors" : [{
+ "set" : {
+ "id" : 17,
+ "size" : 1,
+ "states" : [1,2]
+ },
+ "dbus" : {
+ "path": "/xyz/openbmc_project/led/groups/ddimm27_identify",
+ "interface": "xyz.openbmc_project.Led.Group",
+ "property_name": "Asserted",
+ "property_type": "bool",
+ "property_values" : [false, true]
+ }
+ }]
+ },
+ {
+ "entity_path" : "/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm28",
+ "sensors" : [{
+ "set" : {
+ "id" : 17,
+ "size" : 1,
+ "states" : [1,2]
+ },
+ "dbus" : {
+ "path": "/xyz/openbmc_project/led/groups/ddimm28_identify",
+ "interface": "xyz.openbmc_project.Led.Group",
+ "property_name": "Asserted",
+ "property_type": "bool",
+ "property_values" : [false, true]
+ }
+ }]
+ },
+ {
+ "entity_path" : "/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm29",
+ "sensors" : [{
+ "set" : {
+ "id" : 17,
+ "size" : 1,
+ "states" : [1,2]
+ },
+ "dbus" : {
+ "path": "/xyz/openbmc_project/led/groups/ddimm29_identify",
+ "interface": "xyz.openbmc_project.Led.Group",
+ "property_name": "Asserted",
+ "property_type": "bool",
+ "property_values" : [false, true]
+ }
+ }]
+ },
+ {
+ "entity_path" : "/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm30",
+ "sensors" : [{
+ "set" : {
+ "id" : 17,
+ "size" : 1,
+ "states" : [1,2]
+ },
+ "dbus" : {
+ "path": "/xyz/openbmc_project/led/groups/ddimm30_identify",
+ "interface": "xyz.openbmc_project.Led.Group",
+ "property_name": "Asserted",
+ "property_type": "bool",
+ "property_values" : [false, true]
+ }
+ }]
+ },
+ {
+ "entity_path" : "/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm31",
+ "sensors" : [{
+ "set" : {
+ "id" : 17,
+ "size" : 1,
+ "states" : [1,2]
+ },
+ "dbus" : {
+ "path": "/xyz/openbmc_project/led/groups/ddimm31_identify",
+ "interface": "xyz.openbmc_project.Led.Group",
+ "property_name": "Asserted",
+ "property_type": "bool",
+ "property_values" : [false, true]
+ }
+ }]
+ },
+ {
"entity_path" : "/xyz/openbmc_project/inventory/system/chassis/motherboard/fan0",
"sensors" : [{
"set" : {
@@ -1205,7 +1749,7 @@
},
{
"type" : 45,
- "instance" : 0,
+ "instance" : 1,
"container" : 0,
"sensors" : [{
"set" : {
@@ -1219,8 +1763,8 @@
"property_name": "State",
"property_type": "string",
"property_values": [
- "xyz.openbmc_project.Led.Physical.Action.On || xyz.openbmc_project.Led.Physical.Action.Blink",
- "xyz.openbmc_project.Led.Physical.Action.Off"
+ "xyz.openbmc_project.Led.Physical.Action.Off",
+ "xyz.openbmc_project.Led.Physical.Action.On || xyz.openbmc_project.Led.Physical.Action.Blink"
]
}
}]