commit 357b72dcca2c7aab08c8f8c660c7393c412ac260
author Patrick Williams <patrick@stwcx.xyz> Wed Apr 13 09:01:35 2022 -0500
committer Patrick Williams <patrick@stwcx.xyz> Thu Apr 14 11:05:00 2022 +0000
tree 98a7768a50f8d13043282e2c0e7fc0d7e95e1837
parent 1421a80f9d9796173b04462eb8aabfdcaa29faca

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.
It is time to remove this boolean to make it more observable which
actions are being used in applications.  Map all `true` occurrences to
`action::defer_emit`.  There was one case of an implicit conversion
from a pointer to a boolean, which I think was an unintended parameter
passing, and was cleaned up.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I5eac859a083e014f13794703c1c194e7f3d2a35d

fw-update/activation.hpp

diff --git a/fw-update/activation.hpp b/fw-update/activation.hpp
index ed216d8..d5c2fc7 100644
--- a/fw-update/activation.hpp
+++ b/fw-update/activation.hpp
@@ -88,7 +88,8 @@
      */
     Activation(sdbusplus::bus::bus& bus, std::string objPath,
                Activations activationStatus, UpdateManager* updateManager) :
-        ActivationIntf(bus, objPath.c_str(), true),
+        ActivationIntf(bus, objPath.c_str(),
+                       ActivationIntf::action::defer_emit),
         bus(bus), objPath(objPath), updateManager(updateManager)
     {
         activation(activationStatus);

pldmd/dbus_impl_pdr.hpp

diff --git a/pldmd/dbus_impl_pdr.hpp b/pldmd/dbus_impl_pdr.hpp
index bbc66dc..2a4a889 100644
--- a/pldmd/dbus_impl_pdr.hpp
+++ b/pldmd/dbus_impl_pdr.hpp
@@ -40,7 +40,7 @@
      */
     Pdr(sdbusplus::bus::bus& bus, const std::string& path,
         const pldm_pdr* repo) :
-        PdrIntf(bus, path.c_str(), repo),
+        PdrIntf(bus, path.c_str()),
         pdrRepo(repo){};
 
     /** @brief Implementation for PdrIntf.FindStateEffecterPDR