sdbusplus: object: don't use 'bool' argument constructor
`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.
It is time to remove this boolean to make it more observable which
actions are being used in applications. Map all `true` occurrences to
`action::defer_emit`. There was one case of an implicit conversion
from a pointer to a boolean, which I think was an unintended parameter
passing, and was cleaned up.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I5eac859a083e014f13794703c1c194e7f3d2a35d
diff --git a/fw-update/activation.hpp b/fw-update/activation.hpp
index ed216d8..d5c2fc7 100644
--- a/fw-update/activation.hpp
+++ b/fw-update/activation.hpp
@@ -88,7 +88,8 @@
*/
Activation(sdbusplus::bus::bus& bus, std::string objPath,
Activations activationStatus, UpdateManager* updateManager) :
- ActivationIntf(bus, objPath.c_str(), true),
+ ActivationIntf(bus, objPath.c_str(),
+ ActivationIntf::action::defer_emit),
bus(bus), objPath(objPath), updateManager(updateManager)
{
activation(activationStatus);