commit 364275c7df5ceb85cea89380f4beace5ae5f9f3e
author Alexander Hansen <alexander.hansen@9elements.com> Tue Nov 11 12:31:42 2025 +0100
committer Alexander Hansen <alexander.hansen@9elements.com> Wed Nov 12 10:41:03 2025 +0100
tree 8d57649c708aac80193cbb1e21d18a3fbc531d25
parent 70015ec570dcc174e95546db28e45ee468f51b88

BIOSConfig.Manager: use PDI constants

Pull property names, interface name, ... from PDI and drop a bunch of
local definitions.

The instance path is still remaining as a local definition, patch [1]
has been raised.

Tested: Inspection only.

References:
[1] https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/85118

Change-Id: Ia6601f1fcbe84802820f610ffc717715b85ca7ba
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

libpldmresponder/bios_config.cpp

diff --git a/libpldmresponder/bios_config.cpp b/libpldmresponder/bios_config.cpp
index 401877c..df0d08e 100644
--- a/libpldmresponder/bios_config.cpp
+++ b/libpldmresponder/bios_config.cpp
@@ -502,11 +502,6 @@
 
 void BIOSConfig::updateBaseBIOSTableProperty()
 {
-    constexpr static auto biosConfigPath =
-        "/xyz/openbmc_project/bios_config/manager";
-    constexpr static auto biosConfigInterface =
-        "xyz.openbmc_project.BIOSConfig.Manager";
-    constexpr static auto biosConfigPropertyName = "BaseBIOSTable";
     constexpr static auto dbusProperties = "org.freedesktop.DBus.Properties";
 
     if (baseBIOSTableMaps.empty())
@@ -517,8 +512,8 @@
     try
     {
         auto& bus = dbusHandler->getBus();
-        auto service =
-            dbusHandler->getService(biosConfigPath, biosConfigInterface);
+        auto service = dbusHandler->getService(biosConfigPath,
+                                               BIOSConfigManager::interface);
         auto method = bus.new_method_call(service.c_str(), biosConfigPath,
                                           dbusProperties, "Set");
         std::variant<BaseBIOSTable> value = baseBIOSTableMaps;
@@ -526,7 +521,9 @@
         {
             oemBiosHandler->processOEMBaseBiosTable(baseBIOSTableMaps);
         }
-        method.append(biosConfigInterface, biosConfigPropertyName, value);
+        method.append(BIOSConfigManager::interface,
+                      BIOSConfigManager::property_names::base_bios_table,
+                      value);
         bus.call_noreply(method, dbusTimeout);
     }
     catch (const std::exception& e)
@@ -567,17 +564,17 @@
     }
 
     BaseBIOSTable biosTable{};
-    constexpr auto biosObjPath = "/xyz/openbmc_project/bios_config/manager";
-    constexpr auto biosInterface = "xyz.openbmc_project.BIOSConfig.Manager";
 
     try
     {
         auto& bus = dbusHandler->getBus();
-        auto service = dbusHandler->getService(biosObjPath, biosInterface);
+        auto service = dbusHandler->getService(biosConfigPath,
+                                               BIOSConfigManager::interface);
         auto method =
-            bus.new_method_call(service.c_str(), biosObjPath,
+            bus.new_method_call(service.c_str(), biosConfigPath,
                                 "org.freedesktop.DBus.Properties", "Get");
-        method.append(biosInterface, "BaseBIOSTable");
+        method.append(BIOSConfigManager::interface,
+                      BIOSConfigManager::property_names::base_bios_table);
         auto reply = bus.call(method, dbusTimeout);
         std::variant<BaseBIOSTable> varBiosTable{};
         reply.read(varBiosTable);
@@ -1154,16 +1151,11 @@
 
 void BIOSConfig::listenPendingAttributes()
 {
-    constexpr auto objPath = "/xyz/openbmc_project/bios_config/manager";
-    constexpr auto objInterface = "xyz.openbmc_project.BIOSConfig.Manager";
-
     using namespace sdbusplus::bus::match::rules;
     auto updateBIOSMatch = std::make_unique<sdbusplus::bus::match_t>(
         pldm::utils::DBusHandler::getBus(),
-        propertiesChanged(objPath, objInterface),
+        propertiesChanged(biosConfigPath, BIOSConfigManager::interface),
         [this](sdbusplus::message_t& msg) {
-            constexpr auto propertyName = "PendingAttributes";
-
             using Value =
                 std::variant<std::string, PendingAttributes, BaseBIOSTable>;
             using Properties = std::map<DbusProp, Value>;
@@ -1172,7 +1164,8 @@
             std::string intf;
             msg.read(intf, props);
 
-            auto valPropMap = props.find(propertyName);
+            auto valPropMap = props.find(
+                BIOSConfigManager::property_names::pending_attributes);
             if (valPropMap == props.end())
             {
                 return;