commit 394fac67e98511cabbd34a716fde39c4361f2c1d
author Manojkiran Eda <manojkiran.eda@gmail.com> Thu Jul 22 15:58:29 2021 +0530
committer Manojkiran Eda <manojkiran.eda@gmail.com> Thu Jul 22 16:16:03 2021 +0530
tree 7886e20827c755cb5971456d2a890ff77c68a3f7
parent 2e30eb1a8aad1ec1ac3808d9f2b0083a4f595b00

Rectify few error messages in pldm

There are few places where we try to print a datatype that
is not supported by stdcout/ stdcerr.

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: Ic069fd92ec48bcb0058bcb4d7140e5f59909ca49

libpldmresponder/platform.hpp

diff --git a/libpldmresponder/platform.hpp b/libpldmresponder/platform.hpp
index de81898..397eb75 100644
--- a/libpldmresponder/platform.hpp
+++ b/libpldmresponder/platform.hpp
@@ -334,7 +334,8 @@
             {
                 std::cerr << "The requester sent wrong composite effecter"
                           << " count for the effecter, EFFECTER_ID="
-                          << effecterId << "COMP_EFF_CNT=" << compEffecterCnt
+                          << (unsigned)effecterId
+                          << "COMP_EFF_CNT=" << (unsigned)compEffecterCnt
                           << "\n";
                 return PLDM_ERROR_INVALID_DATA;
             }
@@ -364,9 +365,10 @@
                     !(states->states[bitfieldIndex].byte & (1 << bit)))
                 {
                     std::cerr
-                        << "Invalid state set value, EFFECTER_ID=" << effecterId
-                        << " VALUE=" << stateField[currState].effecter_state
-                        << " COMPOSITE_EFFECTER_ID=" << currState
+                        << "Invalid state set value, EFFECTER_ID="
+                        << (unsigned)effecterId << " VALUE="
+                        << (unsigned)stateField[currState].effecter_state
+                        << " COMPOSITE_EFFECTER_ID=" << (unsigned)currState
                         << " DBUS_PATH=" << dbusMappings[currState].objectPath
                         << "\n";
                     rc = PLDM_PLATFORM_SET_EFFECTER_UNSUPPORTED_SENSORSTATE;
@@ -407,7 +409,7 @@
         catch (const std::out_of_range& e)
         {
             std::cerr << "the effecterId does not exist. effecter id: "
-                      << effecterId << e.what() << '\n';
+                      << (unsigned)effecterId << e.what() << '\n';
         }
 
         return rc;

requester/handler.hpp

diff --git a/requester/handler.hpp b/requester/handler.hpp
index 319cb8e..1bb9cc4 100644
--- a/requester/handler.hpp
+++ b/requester/handler.hpp
@@ -134,10 +134,10 @@
             {
                 std::cerr << "Response not received for the request, instance "
                              "ID expired."
-                          << " EID = " << key.eid
-                          << " INSTANCE_ID = " << key.instanceId
-                          << " TYPE = " << key.type
-                          << " COMMAND = " << key.command << "\n";
+                          << " EID = " << (unsigned)key.eid
+                          << " INSTANCE_ID = " << (unsigned)key.instanceId
+                          << " TYPE = " << (unsigned)key.type
+                          << " COMMAND = " << (unsigned)key.command << "\n";
                 auto& [request, responseHandler, timerInstance] =
                     this->handlers[key];
                 request->stop();