commit 3c8b3e353728899e1c32827c1ade9f4b427006a9
author Pavithra Barithaya <pavithrabarithaya07@gmail.com> Thu Jan 30 10:45:51 2025 +0530
committer ManojKiran Eda <manojkiran.eda@gmail.com> Mon Mar 10 06:18:41 2025 +0000
tree 3dbdf2a558b2aef7d7b6849f0d1cd9e628a42b16
parent 30d679faa05b6cd1ffe2c021ac4e0f3534f04fff

softoff : Migrate to placement_new from reinterpret casting

reinterpret_cast is prohibited by the C++ core guidelines because
it takes the behavior outside the language definition and gives
problems with type safety. Placement-new on the other-hand allows
to control the object storage while still properly instantiating
an object,keeping the behavior inside the C++ language
specification.

Change-Id: I75dd9e2372b32bf4258c497152f61cd0ca6ad9bd
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

softoff/softoff.cpp

diff --git a/softoff/softoff.cpp b/softoff/softoff.cpp
index 1a5911b..3608002 100644
--- a/softoff/softoff.cpp
+++ b/softoff/softoff.cpp
@@ -186,8 +186,7 @@
         {
             for (auto& rep : response)
             {
-                auto softoffPdr =
-                    reinterpret_cast<pldm_state_effecter_pdr*>(rep.data());
+                auto softoffPdr = new (rep.data()) pldm_state_effecter_pdr;
                 effecterID = softoffPdr->effecter_id;
             }
         }
@@ -229,7 +228,7 @@
         pldm_state_sensor_pdr* pdr = nullptr;
         for (auto& rep : Response)
         {
-            pdr = reinterpret_cast<pldm_state_sensor_pdr*>(rep.data());
+            pdr = new (rep.data()) pldm_state_sensor_pdr;
             if (!pdr)
             {
                 error("Failed to get state sensor PDR.");
@@ -244,9 +243,8 @@
 
         for (auto offset = 0; offset < compositeSensorCount; offset++)
         {
-            auto possibleStates =
-                reinterpret_cast<state_sensor_possible_states*>(
-                    possibleStatesStart);
+            auto possibleStates = new (possibleStatesStart)
+                state_sensor_possible_states;
             auto setId = possibleStates->state_set_id;
             auto possibleStateSize = possibleStates->possible_states_size;
 
@@ -284,7 +282,7 @@
                sizeof(pldm_msg_hdr) + sizeof(effecterID) +
                    sizeof(effecterCount) + sizeof(set_effecter_state_field)>
         requestMsg{};
-    auto request = reinterpret_cast<pldm_msg*>(requestMsg.data());
+    auto request = new (requestMsg.data()) pldm_msg;
     set_effecter_state_field stateField{
         PLDM_REQUEST_SET, PLDM_SW_TERM_GRACEFUL_SHUTDOWN_REQUESTED};
     instanceID = instanceIdDb.next(pldmTID);
@@ -346,7 +344,7 @@
         // We've got the response meant for the PLDM request msg that was
         // sent out
         io.set_enabled(Enabled::Off);
-        auto response = reinterpret_cast<pldm_msg*>(responseMsgPtr.get());
+        auto response = new (responseMsgPtr.get()) pldm_msg;
 
         if (srcTID != pldmTID ||
             !pldm_msg_hdr_correlate_response(&request->hdr, &response->hdr))