commit 3dd444d24e7174c71dbaffd3134a5f8ca1e87beb
author Andrew Jeffery <andrew@codeconstruct.com.au> Thu Jul 25 22:00:27 2024 +0930
committer Andrew Jeffery <andrew@codeconstruct.com.au> Mon Jul 29 00:12:22 2024 +0930
tree 24f1c94ef599ab643db459818bb406de9fd0267f
parent bb9daa4cbf7e5153319624d69b811d3f3b9f9fd1

host-bmc: host_pdr_handler: Remove unused fields

```
../host-bmc/host_pdr_handler.hpp:277:9: error: private field 'mctp_fd' is not used [-Werror,-Wunused-private-field]
  277 |     int mctp_fd;
      |         ^
../host-bmc/host_pdr_handler.hpp:292:35: error: private field 'bmcEntityTree' is not used [-Werror,-Wunused-private-field]
  292 |     pldm_entity_association_tree* bmcEntityTree;
      |                                   ^
```

Change-Id: I62a948dff51b184bf44f1053b48d3b512e3e2b72
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

host-bmc/host_pdr_handler.cpp

diff --git a/host-bmc/host_pdr_handler.cpp b/host-bmc/host_pdr_handler.cpp
index 61167ab..3621f92 100644
--- a/host-bmc/host_pdr_handler.cpp
+++ b/host-bmc/host_pdr_handler.cpp
@@ -84,15 +84,15 @@
 }
 
 HostPDRHandler::HostPDRHandler(
-    int mctp_fd, uint8_t mctp_eid, sdeventplus::Event& event, pldm_pdr* repo,
-    const std::string& eventsJsonsDir, pldm_entity_association_tree* entityTree,
+    int /* mctp_fd */, uint8_t mctp_eid, sdeventplus::Event& event,
+    pldm_pdr* repo, const std::string& eventsJsonsDir,
+    pldm_entity_association_tree* entityTree,
     pldm_entity_association_tree* bmcEntityTree,
     pldm::InstanceIdDb& instanceIdDb,
     pldm::requester::Handler<pldm::requester::Request>* handler) :
-    mctp_fd(mctp_fd),
-    mctp_eid(mctp_eid), event(event), repo(repo),
-    stateSensorHandler(eventsJsonsDir), entityTree(entityTree),
-    bmcEntityTree(bmcEntityTree), instanceIdDb(instanceIdDb), handler(handler),
+    mctp_eid(mctp_eid),
+    event(event), repo(repo), stateSensorHandler(eventsJsonsDir),
+    entityTree(entityTree), instanceIdDb(instanceIdDb), handler(handler),
     entityMaps(parseEntityMap(ENTITY_MAP_JSON)), oemUtilsHandler(nullptr)
 {
     mergedHostParents = false;

host-bmc/host_pdr_handler.hpp

diff --git a/host-bmc/host_pdr_handler.hpp b/host-bmc/host_pdr_handler.hpp
index eb299f3..c75c172 100644
--- a/host-bmc/host_pdr_handler.hpp
+++ b/host-bmc/host_pdr_handler.hpp
@@ -273,8 +273,6 @@
     std::optional<uint16_t> getRSI(const PDRList& fruRecordSetPDRs,
                                    const pldm_entity& entity);
 
-    /** @brief fd of MCTP communications socket */
-    int mctp_fd;
     /** @brief MCTP EID of host firmware */
     uint8_t mctp_eid;
     /** @brief reference of main event loop of pldmd, primarily used to schedule
@@ -288,9 +286,6 @@
     /** @brief Pointer to BMC's and Host's entity association tree */
     pldm_entity_association_tree* entityTree;
 
-    /** @brief Pointer to BMC's entity association tree */
-    pldm_entity_association_tree* bmcEntityTree;
-
     /** @brief reference to Instance ID database object, used to obtain PLDM
      * instance IDs
      */