commit 3fbd39ebeedc66e95dac1f529ca32c1f22daed02
author Varsha Kaverappa <vkaverap@in.ibm.com> Mon Sep 28 01:40:22 2020 -0500
committer Sampa Misra <sampmisr@in.ibm.com> Wed Jan 20 23:06:18 2021 -0600
tree 3f8f4d42b5886a846fb8bac42d85e3099469db08
parent cfdbca75ecaca07fb767cd2e3e453154bd069fd9

Inband code update: send PLDM events up for all code update states

send pldm events to Host to respond to the code update commands.

Signed-off-by: Varsha Kaverappa <vkaverap@in.ibm.com>
Change-Id: Iae90a4663d4c5ed20b3a8a6222edb6055a533589

oem/ibm/libpldmresponder/oem_ibm_handler.cpp

diff --git a/oem/ibm/libpldmresponder/oem_ibm_handler.cpp b/oem/ibm/libpldmresponder/oem_ibm_handler.cpp
index 1c6b3fd..09a46a5 100644
--- a/oem/ibm/libpldmresponder/oem_ibm_handler.cpp
+++ b/oem/ibm/libpldmresponder/oem_ibm_handler.cpp
@@ -42,10 +42,11 @@
 }
 
 int pldm::responder::oem_ibm_platform::Handler::
-    oemSetStateEffecterStatesHandler(
-        EntityType entityType, EntityInstance entityInstance,
-        StateSetId stateSetId, CompositeCount compEffecterCnt,
-        const std::vector<set_effecter_state_field>& stateField)
+    OemSetStateEffecterStatesHandler(
+        uint16_t entityType, uint16_t entityInstance, uint16_t stateSetId,
+        uint8_t compEffecterCnt,
+        std::vector<set_effecter_state_field>& stateField,
+        uint16_t /*effecterId*/)
 {
     int rc = PLDM_SUCCESS;
 

oem/ibm/libpldmresponder/oem_ibm_handler.hpp

diff --git a/oem/ibm/libpldmresponder/oem_ibm_handler.hpp b/oem/ibm/libpldmresponder/oem_ibm_handler.hpp
index 17ad008..f8d261d 100644
--- a/oem/ibm/libpldmresponder/oem_ibm_handler.hpp
+++ b/oem/ibm/libpldmresponder/oem_ibm_handler.hpp
@@ -48,10 +48,10 @@
         StateSetId stateSetId, CompositeCount compSensorCnt,
         std::vector<get_sensor_state_field>& stateField);
 
-    int oemSetStateEffecterStatesHandler(
-        EntityType entityType, EntityInstance entityInstance,
-        StateSetId stateSetId, CompositeCount compEffecterCnt,
-        const std::vector<set_effecter_state_field>& stateField);
+    int OemSetStateEffecterStatesHandler(
+        uint16_t entityType, uint16_t entityInstance, uint16_t stateSetId,
+        uint8_t compEffecterCnt,
+        std::vector<set_effecter_state_field>& stateField, uint16_t effecterId);
 
     /** @brief Method to set the platform handler in the
      *         oem_ibm_handler class

oem/ibm/test/libpldmresponder_oem_platform_test.cpp

diff --git a/oem/ibm/test/libpldmresponder_oem_platform_test.cpp b/oem/ibm/test/libpldmresponder_oem_platform_test.cpp
index 64de610..3b2d681 100644
--- a/oem/ibm/test/libpldmresponder_oem_platform_test.cpp
+++ b/oem/ibm/test/libpldmresponder_oem_platform_test.cpp
@@ -33,6 +33,7 @@
     uint16_t stateSetId_ = PLDM_OEM_IBM_BOOT_STATE;
     uint16_t entityInstance_ = 0;
     uint8_t compSensorCnt_ = 1;
+    uint16_t effecterId = 0xA;
     sdbusplus::bus::bus bus(sdbusplus::bus::new_default());
     Requester requester(bus, "/abc/def");
 
@@ -83,24 +84,24 @@
     std::vector<set_effecter_state_field> setEffecterStateField;
     setEffecterStateField.push_back({PLDM_REQUEST_SET, pSideNum});
 
-    rc = oemPlatformHandler->oemSetStateEffecterStatesHandler(
+    rc = oemPlatformHandler->OemSetStateEffecterStatesHandler(
         entityID_, entityInstance_, stateSetId_, compSensorCnt_,
-        setEffecterStateField);
+        setEffecterStateField, effecterId);
     ASSERT_EQ(rc, PLDM_SUCCESS);
 
     entityInstance_ = 2;
-    rc = oemPlatformHandler->oemSetStateEffecterStatesHandler(
+    rc = oemPlatformHandler->OemSetStateEffecterStatesHandler(
         entityID_, entityInstance_, stateSetId_, compSensorCnt_,
-        setEffecterStateField);
+        setEffecterStateField, effecterId);
 
     ASSERT_EQ(rc, PLDM_PLATFORM_INVALID_STATE_VALUE);
 
     entityID_ = 34;
     stateSetId_ = 99;
     entityInstance_ = 0;
-    rc = oemPlatformHandler->oemSetStateEffecterStatesHandler(
+    rc = oemPlatformHandler->OemSetStateEffecterStatesHandler(
         entityID_, entityInstance_, stateSetId_, compSensorCnt_,
-        setEffecterStateField);
+        setEffecterStateField, effecterId);
     ASSERT_EQ(rc, PLDM_PLATFORM_SET_EFFECTER_UNSUPPORTED_SENSORSTATE);
 }