remove the rvalue reference from Request class
the rvalue is causing the buffer to be lost when retrying.
we tried sending msg to Host when Host was off and pldmd crashed
before fix:
pldmd calling setHostState
enter setHostStateSending first Msg: 80 00 03 00 00 00 00 01 00
enter pldm_send with requestMsg.size() 9
enter pldm_send with requestMsg.size() 4162004581
after fix:
pldmd calling setHostState
enter setHostStateSending first Msg: 80 00 03 00 00 00 00 01 00
enter pldm_send with requestMsg.size() 9
enter pldm_send with requestMsg.size() 9
enter pldm_send with requestMsg.size() 9
Response not received for the request, instance ID expired.
EID = 9 INSTANCE_ID= 0 TYPE = 0 COMMAND = 3
into getPLDMVersionHandler callback
Failed to receive response for getPLDMVersion command,
Host seems to be off
Change-Id: Iee9b08db117122eaa07e8b8fd21f47a8ed1fe142
Signed-off-by: Sampa Misra <sampmisr@in.ibm.com>
diff --git a/requester/request.hpp b/requester/request.hpp
index 3b4dbb0..6bb016d 100644
--- a/requester/request.hpp
+++ b/requester/request.hpp
@@ -153,9 +153,9 @@
{}
private:
- int fd; //!< file descriptor of MCTP communications socket
- mctp_eid_t eid; //!< endpoint ID of the remote MCTP endpoint
- pldm::Request&& requestMsg; //!< PLDM request message
+ int fd; //!< file descriptor of MCTP communications socket
+ mctp_eid_t eid; //!< endpoint ID of the remote MCTP endpoint
+ pldm::Request requestMsg; //!< PLDM request message
/** @brief Sends the PLDM request message on the socket
*