commit 48f4f8e377f881676e3ec389eb39053c6cd0fdfc
author Pavithra Barithaya <pavithra.b@ibm.com> Mon Jul 10 04:36:02 2023 -0500
committer Pavithra Barithaya <pavithra.b@ibm.com> Wed Jul 19 04:39:48 2023 +0000
tree 7c22fafa4d63aac91f62b8891c66afd74cbe6775
parent b2d46b7bd812fe7425eedb086d1d8228e57af5f8

clang-error:fix clang-diagnostic-potentially-evaluated-expression error

This error is generated when expression with side effects is evaluated
despite being used as an operand to 'typeid'.

Change-Id: I72daa47f1c5b05b466e1635fe6d547db4b1da34b
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>

fw-update/test/package_parser_test.cpp

diff --git a/fw-update/test/package_parser_test.cpp b/fw-update/test/package_parser_test.cpp
index 1720eb8..4984ffd 100644
--- a/fw-update/test/package_parser_test.cpp
+++ b/fw-update/test/package_parser_test.cpp
@@ -26,7 +26,8 @@
     constexpr uintmax_t pkgSize = 166;
     constexpr std::string_view pkgVersion{"VersionString1"};
     auto parser = parsePkgHeader(fwPkgHdr);
-    EXPECT_EQ(typeid(*parser).name(), typeid(PackageParserV1).name());
+    auto obj = parser.get();
+    EXPECT_EQ(typeid(*obj).name(), typeid(PackageParserV1).name());
     EXPECT_EQ(parser->pkgHeaderSize, fwPkgHdr.size());
     EXPECT_EQ(parser->pkgVersion, pkgVersion);
 
@@ -85,7 +86,8 @@
     constexpr uintmax_t pkgSize = 407;
     constexpr std::string_view pkgVersion{"VersionString1"};
     auto parser = parsePkgHeader(fwPkgHdr);
-    EXPECT_EQ(typeid(*parser).name(), typeid(PackageParserV1).name());
+    auto obj = parser.get();
+    EXPECT_EQ(typeid(*obj).name(), typeid(PackageParserV1).name());
     EXPECT_EQ(parser->pkgHeaderSize, fwPkgHdr.size());
     EXPECT_EQ(parser->pkgVersion, pkgVersion);
 
@@ -173,7 +175,8 @@
     constexpr uintmax_t pkgSize = 166;
     constexpr std::string_view pkgVersion{"VersionString1"};
     auto parser = parsePkgHeader(fwPkgHdr);
-    EXPECT_EQ(typeid(*parser).name(), typeid(PackageParserV1).name());
+    auto obj = parser.get();
+    EXPECT_EQ(typeid(*obj).name(), typeid(PackageParserV1).name());
     EXPECT_EQ(parser->pkgHeaderSize, fwPkgHdr.size());
     EXPECT_EQ(parser->pkgVersion, pkgVersion);
     EXPECT_THROW(parser->parse(fwPkgHdr, pkgSize), std::exception);