PLDM: Implementing Phosphor-Logging/LG2 logging
This commit adds changes in PLDM for implementing
structured LG2 logging, thereby moving away from
std::cout/cerr practice of logging which are
output streams and not logging mechanism.
PLDM now can make use of lg2 features like accurate
CODE LINE Number and CODE_FUNCTION Name and better
detailing in json object values which can be used in
log tracking.
More detailed logging change:
https://gist.github.com/riyadixitagra/c251685c1ba84248181891f7bc282395
Tested:
Ran a power off, on, cycle, and reset-reload.
Change-Id: I0485035f15f278c3fd172f0581b053c1c37f3a5b
Signed-off-by: Riya Dixit <riyadixitagra@gmail.com>
diff --git a/libpldmresponder/pdr_numeric_effecter.hpp b/libpldmresponder/pdr_numeric_effecter.hpp
index df5faf9..d342636 100644
--- a/libpldmresponder/pdr_numeric_effecter.hpp
+++ b/libpldmresponder/pdr_numeric_effecter.hpp
@@ -4,6 +4,10 @@
#include <libpldm/platform.h>
+#include <phosphor-logging/lg2.hpp>
+
+PHOSPHOR_LOG2_USING;
+
namespace pldm
{
namespace responder
@@ -37,7 +41,7 @@
reinterpret_cast<pldm_numeric_effecter_value_pdr*>(entry.data());
if (!pdr)
{
- std::cerr << "Failed to get numeric effecter PDR.\n";
+ error("Failed to get numeric effecter PDR.");
continue;
}
pdr->hdr.record_handle = 0;
@@ -216,8 +220,9 @@
}
catch (const std::exception& e)
{
- std::cerr << "D-Bus object path does not exist, effecter ID: "
- << pdr->effecter_id << "\n";
+ error(
+ "D-Bus object path does not exist, effecter ID: {EFFECTER_ID}",
+ "EFFECTER_ID", static_cast<uint16_t>(pdr->effecter_id));
}
dbusMappings.emplace_back(std::move(dbusMapping));