commit 4bf3ed840f13c31720ffa7c255942f3836402f4f
author Eric Yang <eric.yang.wiwynn@gmail.com> Fri Mar 14 18:45:53 2025 +0800
committer ManojKiran Eda <manojkiran.eda@gmail.com> Wed Mar 19 04:40:59 2025 +0000
tree 07e43bd1d336a6908454c740f0d205e8d7b11380
parent 1b89451bff7ef74978a8fcfc4b34edd3f8ed1ddb

requester: Fix error handling in registerRequest

Add error handling for pollEndpointQueue in registerRequest to
prevent incorrect PLDM_SUCCESS returns.
This ensures SendRecvMsgSender can handle send failures, preventing
discoverMctpTerminusTask from stalling and remaining incomplete.

Change-Id: I153934490ee848166e7dce5892136bbbdeeacdd9
Signed-off-by: Eric Yang <eric.yang.wiwynn@gmail.com>

requester/handler.hpp

diff --git a/requester/handler.hpp b/requester/handler.hpp
index 33d9cb9..3677243 100644
--- a/requester/handler.hpp
+++ b/requester/handler.hpp
@@ -287,7 +287,14 @@
         }
 
         /* try to send new request if the endpoint is free */
-        pollEndpointQueue(eid);
+        auto rc = pollEndpointQueue(eid);
+        if (rc != PLDM_SUCCESS)
+        {
+            error(
+                "Failed to process request queue for EID {EID}, response code {RC}.",
+                "EID", eid, "RC", rc);
+            return rc;
+        }
 
         return PLDM_SUCCESS;
     }