treewide: remove 'using namespace' from headers
Using namespace at global scope in a header file violates the cpp core
guidelines. Quoting the guidelines:
"Doing so takes away an #includer’s ability to effectively
disambiguate and to use alternatives. It also makes #included headers
order-dependent as they might have different meaning when included in
different orders."
For further reading:
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rs-using-directive
The guidelines don't call out using using namespace from namespace
scope, but it is only marginally less problematic and still unexpected,
so this patch removes those as well.
The process used to do the update is roughly:
1 - git grep 'using namespace' **.hpp
2 - For each instance, remove the offending 'using namespace' line
3 - build
4 - add 'using namespace' to cpp files or fully resolve types in hpp
files until the project builds again.
Further cleanup is possible - for example cpp files could be scrubbed
for unnecessary namespace qualification - this was not done here to make
review as simple as possible.
Change-Id: I4931f5e78a1b5b74b4a4774c035a549f4d59b91a
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
diff --git a/host-bmc/dbus_to_event_handler.hpp b/host-bmc/dbus_to_event_handler.hpp
index 2a25243..8818d67 100644
--- a/host-bmc/dbus_to_event_handler.hpp
+++ b/host-bmc/dbus_to_event_handler.hpp
@@ -8,16 +8,13 @@
#include <map>
-using namespace pldm::dbus_api;
-using namespace pldm::responder;
-
namespace pldm
{
using SensorId = uint16_t;
using DbusObjMaps =
- std::map<SensorId,
- std::tuple<pdr_utils::DbusMappings, pdr_utils::DbusValMaps>>;
+ std::map<SensorId, std::tuple<pldm::responder::pdr_utils::DbusMappings,
+ pldm::responder::pdr_utils::DbusValMaps>>;
using sensorEvent =
std::function<void(SensorId sensorId, const DbusObjMaps& dbusMaps)>;
@@ -44,7 +41,7 @@
* @param[in] handler - PLDM request handler
*/
explicit DbusToPLDMEvent(
- int mctp_fd, uint8_t mctp_eid, Requester& requester,
+ int mctp_fd, uint8_t mctp_eid, pldm::dbus_api::Requester& requester,
pldm::requester::Handler<pldm::requester::Request>* handler);
public:
@@ -52,7 +49,7 @@
* @param[in] repo - pdr utils repo object
* @param[in] dbusMaps - The map of D-Bus mapping and value
*/
- void listenSensorEvent(const pdr_utils::Repo& repo,
+ void listenSensorEvent(const pldm::responder::pdr_utils::Repo& repo,
const DbusObjMaps& dbusMaps);
private:
@@ -77,7 +74,7 @@
/** @brief reference to Requester object, primarily used to access API to
* obtain PLDM instance id.
*/
- Requester& requester;
+ pldm::dbus_api::Requester& requester;
/** @brief D-Bus property changed signal match */
std::vector<std::unique_ptr<sdbusplus::bus::match::match>>