treewide: remove 'using namespace' from headers
Using namespace at global scope in a header file violates the cpp core
guidelines. Quoting the guidelines:
"Doing so takes away an #includer’s ability to effectively
disambiguate and to use alternatives. It also makes #included headers
order-dependent as they might have different meaning when included in
different orders."
For further reading:
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rs-using-directive
The guidelines don't call out using using namespace from namespace
scope, but it is only marginally less problematic and still unexpected,
so this patch removes those as well.
The process used to do the update is roughly:
1 - git grep 'using namespace' **.hpp
2 - For each instance, remove the offending 'using namespace' line
3 - build
4 - add 'using namespace' to cpp files or fully resolve types in hpp
files until the project builds again.
Further cleanup is possible - for example cpp files could be scrubbed
for unnecessary namespace qualification - this was not done here to make
review as simple as possible.
Change-Id: I4931f5e78a1b5b74b4a4774c035a549f4d59b91a
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
diff --git a/libpldmresponder/bios_attribute.hpp b/libpldmresponder/bios_attribute.hpp
index ebdf1dc..ca4ae70 100644
--- a/libpldmresponder/bios_attribute.hpp
+++ b/libpldmresponder/bios_attribute.hpp
@@ -22,7 +22,6 @@
{
using Json = nlohmann::json;
-using namespace pldm::utils;
/** @class BIOSAttribute
* @brief Provide interfaces to implement specific types of attributes
@@ -34,7 +33,8 @@
* @param[in] entry - Json Object
* @param[in] dbusHandler - Dbus Handler
*/
- BIOSAttribute(const Json& entry, DBusHandler* const dbusHandler);
+ BIOSAttribute(const Json& entry,
+ pldm::utils::DBusHandler* const dbusHandler);
/** Virtual destructor
*/
@@ -75,7 +75,7 @@
*/
virtual int updateAttrVal(Table& newValue, uint16_t attrHdl,
uint8_t attrType,
- const PropertyValue& newPropVal) = 0;
+ const pldm::utils::PropertyValue& newPropVal) = 0;
/** @brief Generate attribute entry by the spec DSP0247_1.0.0 Table 14
* @param[in] attributevalue - attribute value(Enumeration, String and
@@ -87,7 +87,7 @@
Table& attrValueEntry) = 0;
/** @brief Method to return the D-Bus map */
- std::optional<DBusMapping> getDBusMap();
+ std::optional<pldm::utils::DBusMapping> getDBusMap();
/** @brief Name of this attribute */
const std::string name;
@@ -101,10 +101,10 @@
protected:
/** @brief dbus backend, nullopt if this attribute is read-only*/
- std::optional<DBusMapping> dBusMap;
+ std::optional<pldm::utils::DBusMapping> dBusMap;
/** @brief dbus handler */
- DBusHandler* const dbusHandler;
+ pldm::utils::DBusHandler* const dbusHandler;
};
} // namespace bios