treewide: remove 'using namespace' from headers
Using namespace at global scope in a header file violates the cpp core
guidelines. Quoting the guidelines:
"Doing so takes away an #includer’s ability to effectively
disambiguate and to use alternatives. It also makes #included headers
order-dependent as they might have different meaning when included in
different orders."
For further reading:
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rs-using-directive
The guidelines don't call out using using namespace from namespace
scope, but it is only marginally less problematic and still unexpected,
so this patch removes those as well.
The process used to do the update is roughly:
1 - git grep 'using namespace' **.hpp
2 - For each instance, remove the offending 'using namespace' line
3 - build
4 - add 'using namespace' to cpp files or fully resolve types in hpp
files until the project builds again.
Further cleanup is possible - for example cpp files could be scrubbed
for unnecessary namespace qualification - this was not done here to make
review as simple as possible.
Change-Id: I4931f5e78a1b5b74b4a4774c035a549f4d59b91a
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
diff --git a/libpldmresponder/fru_parser.hpp b/libpldmresponder/fru_parser.hpp
index fc3234e..ce6f619 100644
--- a/libpldmresponder/fru_parser.hpp
+++ b/libpldmresponder/fru_parser.hpp
@@ -40,17 +40,20 @@
{
namespace fs = std::filesystem;
-using namespace dbus;
-using namespace fru;
// DBusLookupInfo contains info to lookup in the D-Bus inventory, D-Bus
// inventory service bus name, root path of the inventory D-Bus objects and list
// of xyz.openbmc_project.Inventory.Item.* interface names.
-using DBusLookupInfo = std::tuple<Service, RootPath, Interfaces>;
-using FieldInfo = std::tuple<Interface, Property, PropertyType, FieldType>;
+using DBusLookupInfo =
+ std::tuple<pldm::responder::dbus::Service, pldm::responder::dbus::RootPath,
+ pldm::responder::dbus::Interfaces>;
+using FieldInfo = std::tuple<
+ pldm::responder::dbus::Interface, pldm::responder::dbus::Property,
+ pldm::responder::dbus::PropertyType, pldm::responder::fru::FieldType>;
using FruRecordInfo =
- std::tuple<RecordType, EncodingType, std::vector<FieldInfo>>;
+ std::tuple<pldm::responder::fru::RecordType,
+ pldm::responder::fru::EncodingType, std::vector<FieldInfo>>;
using FruRecordInfos = std::vector<FruRecordInfo>;
using ItemIntfName = std::string;
@@ -94,12 +97,14 @@
* @return return the info create the PLDM FRU records from inventory D-Bus
* objects
*/
- const FruRecordInfos& getRecordInfo(const Interface& intf) const
+ const FruRecordInfos&
+ getRecordInfo(const pldm::responder::dbus::Interface& intf) const
{
return recordMap.at(intf);
}
- EntityType getEntityType(const Interface& intf) const
+ pldm::responder::dbus::EntityType
+ getEntityType(const pldm::responder::dbus::Interface& intf) const
{
return intfToEntityType.at(intf);
}
@@ -134,7 +139,9 @@
std::optional<DBusLookupInfo> lookupInfo;
FruRecordMap recordMap;
- std::map<Interface, EntityType> intfToEntityType;
+ std::map<pldm::responder::dbus::Interface,
+ pldm::responder::dbus::EntityType>
+ intfToEntityType;
};
} // namespace fru_parser