treewide: remove 'using namespace' from headers
Using namespace at global scope in a header file violates the cpp core
guidelines. Quoting the guidelines:
"Doing so takes away an #includer’s ability to effectively
disambiguate and to use alternatives. It also makes #included headers
order-dependent as they might have different meaning when included in
different orders."
For further reading:
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rs-using-directive
The guidelines don't call out using using namespace from namespace
scope, but it is only marginally less problematic and still unexpected,
so this patch removes those as well.
The process used to do the update is roughly:
1 - git grep 'using namespace' **.hpp
2 - For each instance, remove the offending 'using namespace' line
3 - build
4 - add 'using namespace' to cpp files or fully resolve types in hpp
files until the project builds again.
Further cleanup is possible - for example cpp files could be scrubbed
for unnecessary namespace qualification - this was not done here to make
review as simple as possible.
Change-Id: I4931f5e78a1b5b74b4a4774c035a549f4d59b91a
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
diff --git a/requester/request.hpp b/requester/request.hpp
index 6bb016d..f1a91d7 100644
--- a/requester/request.hpp
+++ b/requester/request.hpp
@@ -18,8 +18,6 @@
namespace requester
{
-using namespace std::chrono;
-
/** @class RequestRetryTimer
*
* The abstract base class for implementing the PLDM request retry logic. This
@@ -44,7 +42,7 @@
* @param[in] timeout - time to wait between each retry in milliseconds
*/
explicit RequestRetryTimer(sdeventplus::Event& event, uint8_t numRetries,
- milliseconds timeout) :
+ std::chrono::milliseconds timeout) :
event(event),
numRetries(numRetries), timeout(timeout),
@@ -67,7 +65,8 @@
{
if (numRetries)
{
- timer.start(duration_cast<microseconds>(timeout), true);
+ timer.start(duration_cast<std::chrono::microseconds>(timeout),
+ true);
}
}
catch (const std::runtime_error& e)
@@ -94,7 +93,8 @@
protected:
sdeventplus::Event& event; //!< reference to PLDM daemon's main event loop
uint8_t numRetries; //!< number of request retries
- milliseconds timeout; //!< time to wait between each retry in milliseconds
+ std::chrono::milliseconds
+ timeout; //!< time to wait between each retry in milliseconds
phosphor::Timer timer; //!< manages starting timers and handling timeouts
/** @brief Sends the PLDM request message
@@ -147,7 +147,7 @@
*/
explicit Request(int fd, mctp_eid_t eid, sdeventplus::Event& event,
pldm::Request&& requestMsg, uint8_t numRetries,
- milliseconds timeout) :
+ std::chrono::milliseconds timeout) :
RequestRetryTimer(event, numRetries, timeout),
fd(fd), eid(eid), requestMsg(std::move(requestMsg))
{}