oem-ibm: Fix size corruption during DMA transfer
When the remote terminus performs read/write operations on BMC
utilizing DMA(Direct Memory Access), the BMC verifies the data length
to be transferred and segments it into chunks if the length exceeds
the maximum allowable size (8384512 byte) by DMA. This modification
addresses an issue in PLDM where it incorrectly reports data transfer
status to the remote terminus, including the leftover length in its
response, which is erroneous. With this enhancement, PLDM now delivers
accurate responses with the appropriate length specified.
Tested:
Tested IPL flow on simulator.
Change-Id: I48d4f825f1e049b06f291e401a02f8dacc1ad970
Signed-off-by: Kamalkumar Patel <kamalkumar.patel@ibm.com>
diff --git a/oem/ibm/libpldmresponder/file_io_by_type.hpp b/oem/ibm/libpldmresponder/file_io_by_type.hpp
index 1665221..c9056e9 100644
--- a/oem/ibm/libpldmresponder/file_io_by_type.hpp
+++ b/oem/ibm/libpldmresponder/file_io_by_type.hpp
@@ -36,13 +36,13 @@
* file types need to override this method to do the file specific
* processing
* @param[in] offset - offset to read
- * @param[in/out] length - length to be read mentioned by Host
+ * @param[in] length - length to be read mentioned by Host
* @param[in] address - DMA address
* @param[in] oemPlatformHandler - oem handler for PLDM platform related
* tasks
* @return PLDM status code
*/
- virtual int readIntoMemory(uint32_t offset, uint32_t& length,
+ virtual int readIntoMemory(uint32_t offset, uint32_t length,
uint64_t address,
oem_platform::Handler* oemPlatformHandler) = 0;
diff --git a/oem/ibm/libpldmresponder/file_io_type_cert.cpp b/oem/ibm/libpldmresponder/file_io_type_cert.cpp
index a5b4e21..c1788e3 100644
--- a/oem/ibm/libpldmresponder/file_io_type_cert.cpp
+++ b/oem/ibm/libpldmresponder/file_io_type_cert.cpp
@@ -50,7 +50,7 @@
return rc;
}
-int CertHandler::readIntoMemory(uint32_t offset, uint32_t& length,
+int CertHandler::readIntoMemory(uint32_t offset, uint32_t length,
uint64_t address,
oem_platform::Handler* /*oemPlatformHandler*/)
{
diff --git a/oem/ibm/libpldmresponder/file_io_type_cert.hpp b/oem/ibm/libpldmresponder/file_io_type_cert.hpp
index f1f4cd7..75f0e69 100644
--- a/oem/ibm/libpldmresponder/file_io_type_cert.hpp
+++ b/oem/ibm/libpldmresponder/file_io_type_cert.hpp
@@ -31,7 +31,7 @@
virtual int writeFromMemory(uint32_t offset, uint32_t length,
uint64_t address,
oem_platform::Handler* /*oemPlatformHandler*/);
- virtual int readIntoMemory(uint32_t offset, uint32_t& length,
+ virtual int readIntoMemory(uint32_t offset, uint32_t length,
uint64_t address,
oem_platform::Handler* /*oemPlatformHandler*/);
virtual int read(uint32_t offset, uint32_t& length, Response& response,
diff --git a/oem/ibm/libpldmresponder/file_io_type_dump.cpp b/oem/ibm/libpldmresponder/file_io_type_dump.cpp
index 83343b7..b5bc53c 100644
--- a/oem/ibm/libpldmresponder/file_io_type_dump.cpp
+++ b/oem/ibm/libpldmresponder/file_io_type_dump.cpp
@@ -324,7 +324,7 @@
return PLDM_ERROR;
}
-int DumpHandler::readIntoMemory(uint32_t offset, uint32_t& length,
+int DumpHandler::readIntoMemory(uint32_t offset, uint32_t length,
uint64_t address,
oem_platform::Handler* /*oemPlatformHandler*/)
{
diff --git a/oem/ibm/libpldmresponder/file_io_type_dump.hpp b/oem/ibm/libpldmresponder/file_io_type_dump.hpp
index dbb5ba7..c11bcae 100644
--- a/oem/ibm/libpldmresponder/file_io_type_dump.hpp
+++ b/oem/ibm/libpldmresponder/file_io_type_dump.hpp
@@ -26,7 +26,7 @@
uint64_t address,
oem_platform::Handler* /*oemPlatformHandler*/);
- virtual int readIntoMemory(uint32_t offset, uint32_t& length,
+ virtual int readIntoMemory(uint32_t offset, uint32_t length,
uint64_t address,
oem_platform::Handler* /*oemPlatformHandler*/);
diff --git a/oem/ibm/libpldmresponder/file_io_type_lid.hpp b/oem/ibm/libpldmresponder/file_io_type_lid.hpp
index 8affa8a..11be0e6 100644
--- a/oem/ibm/libpldmresponder/file_io_type_lid.hpp
+++ b/oem/ibm/libpldmresponder/file_io_type_lid.hpp
@@ -166,7 +166,7 @@
return rc;
}
- virtual int readIntoMemory(uint32_t offset, uint32_t& length,
+ virtual int readIntoMemory(uint32_t offset, uint32_t length,
uint64_t address,
oem_platform::Handler* oemPlatformHandler)
{
diff --git a/oem/ibm/libpldmresponder/file_io_type_pcie.hpp b/oem/ibm/libpldmresponder/file_io_type_pcie.hpp
index 947d397..6c3fad8 100644
--- a/oem/ibm/libpldmresponder/file_io_type_pcie.hpp
+++ b/oem/ibm/libpldmresponder/file_io_type_pcie.hpp
@@ -31,7 +31,7 @@
virtual int fileAck(uint8_t fileStatus);
- virtual int readIntoMemory(uint32_t /*offset*/, uint32_t& /*length*/,
+ virtual int readIntoMemory(uint32_t /*offset*/, uint32_t /*length*/,
uint64_t /*address*/,
oem_platform::Handler* /*oemPlatformHandler*/)
{
diff --git a/oem/ibm/libpldmresponder/file_io_type_pel.cpp b/oem/ibm/libpldmresponder/file_io_type_pel.cpp
index 458697b..8fe6d76 100644
--- a/oem/ibm/libpldmresponder/file_io_type_pel.cpp
+++ b/oem/ibm/libpldmresponder/file_io_type_pel.cpp
@@ -91,7 +91,7 @@
}
} // namespace detail
-int PelHandler::readIntoMemory(uint32_t offset, uint32_t& length,
+int PelHandler::readIntoMemory(uint32_t offset, uint32_t length,
uint64_t address,
oem_platform::Handler* /*oemPlatformHandler*/)
{
diff --git a/oem/ibm/libpldmresponder/file_io_type_pel.hpp b/oem/ibm/libpldmresponder/file_io_type_pel.hpp
index b7a43b1..02cca16 100644
--- a/oem/ibm/libpldmresponder/file_io_type_pel.hpp
+++ b/oem/ibm/libpldmresponder/file_io_type_pel.hpp
@@ -23,7 +23,7 @@
uint64_t address,
oem_platform::Handler* /*oemPlatformHandler*/);
- virtual int readIntoMemory(uint32_t offset, uint32_t& length,
+ virtual int readIntoMemory(uint32_t offset, uint32_t length,
uint64_t address,
oem_platform::Handler* /*oemPlatformHandler*/);
diff --git a/oem/ibm/libpldmresponder/file_io_type_progress_src.hpp b/oem/ibm/libpldmresponder/file_io_type_progress_src.hpp
index 36f7ccb..ca0ef25 100644
--- a/oem/ibm/libpldmresponder/file_io_type_progress_src.hpp
+++ b/oem/ibm/libpldmresponder/file_io_type_progress_src.hpp
@@ -30,7 +30,7 @@
int write(const char* buffer, uint32_t offset, uint32_t& length,
oem_platform::Handler* oemPlatformHandler) override;
- int readIntoMemory(uint32_t /*offset*/, uint32_t& /*length*/,
+ int readIntoMemory(uint32_t /*offset*/, uint32_t /*length*/,
uint64_t /*address*/,
oem_platform::Handler* /*oemPlatformHandler*/) override
{
diff --git a/oem/ibm/libpldmresponder/file_io_type_vpd.hpp b/oem/ibm/libpldmresponder/file_io_type_vpd.hpp
index d5cf412..8690116 100644
--- a/oem/ibm/libpldmresponder/file_io_type_vpd.hpp
+++ b/oem/ibm/libpldmresponder/file_io_type_vpd.hpp
@@ -26,7 +26,7 @@
{
return PLDM_ERROR_UNSUPPORTED_PLDM_CMD;
}
- virtual int readIntoMemory(uint32_t /*offset*/, uint32_t& /*length*/,
+ virtual int readIntoMemory(uint32_t /*offset*/, uint32_t /*length*/,
uint64_t /*address*/,
oem_platform::Handler* /*oemPlatformHandler*/)
{