commit 5b71b86fa4c6ddd9526a76b00728c59bb92cff0a
author vkaverap@in.ibm.com <vkaverap@in.ibm.com> Mon Aug 21 05:19:04 2023 +0000
committer ManojKiran Eda <manojkiran.eda@gmail.com> Tue Sep 26 08:01:39 2023 +0000
tree 8e17334a0a220479250ffbd4ed552870b7121872
parent 682ee18c89fe6c52bff33ad4deae5726c8fc9069

PLDM: 5 sec timeout for dbus calls without reply

This commit adds 5 second dbus timeout value to dbus calls with no reply. Previously a commit was merged that included 5 seconds dbus timeout value for all dbus call with reply.

This is added to make sure PLDM does not wait for more than 5 seconds when a dbus call is made with or without reply if no response is received from other daemon or host.

The 5 second timeout value is overridden to 10 seconds in meta-ibm layer

Change-Id: Ic20005d903732ac58bb22a657bf1b0c07439d435
Signed-off-by: vkaverap@in.ibm.com <vkaverap@in.ibm.com>

common/utils.cpp

diff --git a/common/utils.cpp b/common/utils.cpp
index d44ae59..9162405 100644
--- a/common/utils.cpp
+++ b/common/utils.cpp
@@ -468,7 +468,7 @@
                                           logInterface, "Create");
         std::map<std::string, std::string> addlData{};
         method.append(errorMsg, severity, addlData);
-        bus.call_noreply(method);
+        bus.call_noreply(method, dbusTimeout);
     }
     catch (const std::exception& e)
     {
@@ -489,7 +489,7 @@
             service.c_str(), dBusMap.objectPath.c_str(), dbusProperties, "Set");
         method.append(dBusMap.interface.c_str(), dBusMap.propertyName.c_str(),
                       variant);
-        bus.call_noreply(method);
+        bus.call_noreply(method, dbusTimeout);
     };
 
     if (dBusMap.propertyType == "uint8_t")

common/utils.hpp

diff --git a/common/utils.hpp b/common/utils.hpp
index d78d172..654b0b4 100644
--- a/common/utils.hpp
+++ b/common/utils.hpp
@@ -28,6 +28,11 @@
 using microsec = std::chrono::microseconds;
 using sec = std::chrono::seconds;
 
+constexpr uint64_t dbusTimeout =
+    std::chrono::duration_cast<std::chrono::microseconds>(
+        std::chrono::seconds(DBUS_TIMEOUT))
+        .count();
+
 namespace pldm
 {
 namespace utils