commit 5e3a24788c27782476b5258eca2b247b9bcbea8a
author Pavithra Barithaya <pavithra.b@ibm.com> Mon Jul 10 08:43:59 2023 -0500
committer Pavithra Barithaya <pavithrabarithaya07@gmail.com> Wed Apr 10 06:02:31 2024 -0500
tree 22b1b7c3922dd7fbf8e8c718de5ea0aa119a46b7
parent cfefc15d0a19954eecd4691ec34de04436c2879c

clang-error: fix clang-analyzer-deadcode.DeadStores error

This clang error is generated when the value stored to a variable
is never read in the code.

Change-Id: Ib68741b3aaf8856010d0073675abc2fdb3012712
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>

oem/ibm/libpldmresponder/file_io_type_dump.cpp

diff --git a/oem/ibm/libpldmresponder/file_io_type_dump.cpp b/oem/ibm/libpldmresponder/file_io_type_dump.cpp
index 811f3fb..f1c6bec 100644
--- a/oem/ibm/libpldmresponder/file_io_type_dump.cpp
+++ b/oem/ibm/libpldmresponder/file_io_type_dump.cpp
@@ -188,7 +188,9 @@
         {
             sock = -errno;
             close(DumpHandler::fd);
-            error("DumpHandler::writeFromMemory: setupUnixSocket() failed");
+            error(
+                "DumpHandler::writeFromMemory: setupUnixSocket() failed ERR={ERR_NO}",
+                "ERR_NO", sock);
             std::remove(socketInterface.c_str());
             return PLDM_ERROR;
         }
@@ -208,7 +210,8 @@
         close(DumpHandler::fd);
         auto socketInterface = getOffloadUri(fileHandle);
         std::remove(socketInterface.c_str());
-        error("DumpHandler::write: writeToUnixSocket() failed");
+        error("DumpHandler::write: writeToUnixSocket() failed ERR={RC_VAL}",
+              "RC_VAL", rc);
         return PLDM_ERROR;
     }
 

oem/ibm/test/libpldmresponder_fileio_test.cpp

diff --git a/oem/ibm/test/libpldmresponder_fileio_test.cpp b/oem/ibm/test/libpldmresponder_fileio_test.cpp
index 18b7970..d9d68e7 100644
--- a/oem/ibm/test/libpldmresponder_fileio_test.cpp
+++ b/oem/ibm/test/libpldmresponder_fileio_test.cpp
@@ -980,6 +980,7 @@
     auto fd = mkstemp(tmplt);
     std::vector<uint8_t> in = {100, 10, 56, 78, 34, 56, 79, 235, 111};
     rc = write(fd, in.data(), in.size());
+    ASSERT_NE(rc, PLDM_ERROR);
     close(fd);
     length = in.size() + 1000;
     rc = handler.readFile(tmplt, 0, length, response);

oem/ibm/test/libpldmresponder_oem_platform_test.cpp

diff --git a/oem/ibm/test/libpldmresponder_oem_platform_test.cpp b/oem/ibm/test/libpldmresponder_oem_platform_test.cpp
index 967cc08..55768d5 100644
--- a/oem/ibm/test/libpldmresponder_oem_platform_test.cpp
+++ b/oem/ibm/test/libpldmresponder_oem_platform_test.cpp
@@ -80,12 +80,14 @@
     std::vector<get_sensor_state_field> stateField1;
     rc = oemPlatformHandler->getOemStateSensorReadingsHandler(
         entityID_, entityInstance_, stateSetId_, compSensorCnt_, stateField1);
+    ASSERT_EQ(rc, PLDM_SUCCESS);
     ASSERT_EQ(stateField1.size(), 1);
     ASSERT_EQ(stateField1[0].event_state, tSideNum);
 
     entityInstance_ = 2;
     rc = oemPlatformHandler->getOemStateSensorReadingsHandler(
         entityID_, entityInstance_, stateSetId_, compSensorCnt_, stateField1);
+    ASSERT_EQ(rc, PLDM_SUCCESS);
     ASSERT_EQ(stateField1[0].event_state, PLDM_SENSOR_UNKNOWN);
 
     entityID_ = 40;