commit 60c186b92abb1ba7de2db3a2a882ee91b6c753ec
author Jayashankar Padath <jayashankar.padath@in.ibm.com> Wed Sep 15 18:22:31 2021 -0500
committer ManojKiran Eda <manojkiran.eda@gmail.com> Thu Oct 07 14:22:32 2021 +0000
tree 2474ac18cf7d5f57ce9ab5bf2ab6fb1287b91905
parent 70ac60b0c03e98d994437d75c0e6f7af7ea1d619

oem-ibm: Resource dump related fixes

This commit include following changes:

1. Allow the empty string as resource dump selector
2. Avoid setting the resource dump id explicitly as notify method
   takes care of the same. This code was causing error when the
   resource dump is getting initiated from host

Tested and verified that resource dump initiation from host is
getting completed without any error.

Signed-off-by: Jayashankar Padath <jayashankar.padath@in.ibm.com>
Change-Id: If15f1f65c6a3a801b0f5ea622b0b77f30b9525c4

oem/ibm/libpldmresponder/file_io_type_dump.cpp

diff --git a/oem/ibm/libpldmresponder/file_io_type_dump.cpp b/oem/ibm/libpldmresponder/file_io_type_dump.cpp
index 985a278..37cbb56 100644
--- a/oem/ibm/libpldmresponder/file_io_type_dump.cpp
+++ b/oem/ibm/libpldmresponder/file_io_type_dump.cpp
@@ -115,23 +115,6 @@
     {
         // Setting the Notify path for resource dump
         notifyObjPath = resDumpObjPath;
-
-        uint32_t sourceDumpId = fileHandle;
-        auto path = findDumpObjPath(fileHandle);
-
-        pldm::utils::PropertyValue propValue{sourceDumpId};
-
-        DBusMapping dbusMapping{path, resDumpEntry, "SourceDumpId", "uint32_t"};
-        try
-        {
-            pldm::utils::DBusHandler().setDbusProperty(dbusMapping, propValue);
-        }
-        catch (const std::exception& e)
-        {
-            std::cerr << "failed to make a d-bus call to DUMP manager to set "
-                         "resource dump SourceDumpId, ERROR="
-                      << e.what() << "\n";
-        }
     }
 
     try

oem/ibm/requester/dbus_to_file_handler.cpp

diff --git a/oem/ibm/requester/dbus_to_file_handler.cpp b/oem/ibm/requester/dbus_to_file_handler.cpp
index 44eb5f7..5f0d7b8 100644
--- a/oem/ibm/requester/dbus_to_file_handler.cpp
+++ b/oem/ibm/requester/dbus_to_file_handler.cpp
@@ -113,28 +113,6 @@
 void DbusToFileHandler::processNewResourceDump(
     const std::string& vspString, const std::string& resDumpReqPass)
 {
-    // This needs special handling in later point of time. Resource dump without
-    // the vsp string is supposed to be a non-disruptive system dump.
-    if (vspString.empty())
-    {
-        std::cerr << "Empty vsp string"
-                  << "\n";
-        PropertyValue value{resDumpStatus};
-        DBusMapping dbusMapping{resDumpCurrentObjPath, resDumpProgressIntf,
-                                "Status", "string"};
-        try
-        {
-            pldm::utils::DBusHandler().setDbusProperty(dbusMapping, value);
-        }
-        catch (const std::exception& e)
-        {
-            std::cerr << "failed to set resource dump operation status, "
-                         "ERROR="
-                      << e.what() << "\n";
-        }
-        return;
-    }
-
     namespace fs = std::filesystem;
     const fs::path resDumpDirPath = "/var/lib/pldm/resourcedump";