commit 6254daf074596f429c610cd37ec2e11c91020c67
author Manojkiran Eda <manojkiran.eda@gmail.com> Wed Jul 16 11:30:54 2025 +0530
committer Manojkiran Eda <manojkiran.eda@gmail.com> Wed Jul 16 11:46:21 2025 +0530
tree c1baa203fa4d48dd4d1743ca1d26a2dcdc9729b9
parent e1f902c110b44da80c906c527c0d2fc10ae98859

pldmtool: Correct bit defs in getFirmwareParameter

The definitions for bit 2 and bit 3 in getFirmwareParameters were
inadvertently swapped in pldmtool, contrary to the DSP0267 v1.3.0
specification. This change restores the correct mapping to align with
the standard.

Resolves : openbmc/pldm#50

Change-Id: Ib36af27557bb3a509158e6307fa4e5c6686d3649
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

pldmtool/pldm_fw_update_cmd.cpp

diff --git a/pldmtool/pldm_fw_update_cmd.cpp b/pldmtool/pldm_fw_update_cmd.cpp
index d992d94..951670c 100644
--- a/pldmtool/pldm_fw_update_cmd.cpp
+++ b/pldmtool/pldm_fw_update_cmd.cpp
@@ -273,17 +273,6 @@
 
         if (fwParams.capabilities_during_update.bits.bit2)
         {
-            capabilitiesDuringUpdate["Firmware Device Partial Updates"] =
-                "Firmware Device can support a partial update, whereby a package which contains a component image set that is a subset of all components currently residing on the FD, can be transferred.";
-        }
-        else
-        {
-            capabilitiesDuringUpdate["Firmware Device Partial Updates"] =
-                "Firmware Device cannot accept a partial update and all components present on the FD shall be updated.";
-        }
-
-        if (fwParams.capabilities_during_update.bits.bit3)
-        {
             capabilitiesDuringUpdate
                 ["Firmware Device Host Functionality during Firmware Update"] =
                     "Device will not revert to previous component image upon failure, timeout or cancellation of the transfer";
@@ -295,6 +284,17 @@
                     "Device will revert to previous component image upon failure, timeout or cancellation of the transfer";
         }
 
+        if (fwParams.capabilities_during_update.bits.bit3)
+        {
+            capabilitiesDuringUpdate["Firmware Device Partial Updates"] =
+                "Firmware Device can support a partial update, whereby a package which contains a component image set that is a subset of all components currently residing on the FD, can be transferred.";
+        }
+        else
+        {
+            capabilitiesDuringUpdate["Firmware Device Partial Updates"] =
+                "Firmware Device cannot accept a partial update and all components present on the FD shall be updated.";
+        }
+
         if (fwParams.capabilities_during_update.bits.bit4)
         {
             capabilitiesDuringUpdate["Firmware Device Update Mode Restrictions"] =