PLDM: Fixed broken testcase for upstream
- This commit fixed broken testcase for upstream.
- Testcase was broken due to container id got changed from
0 to 1.
Container ID changed as part of this commit:
97296e0355bb93fec84daa4623f4873f5f3875af
Signed-off-by: Patel-Kamalkumar <kamalkumar.patel@ibm.com>
Change-Id: Ib40d2334ddf742f40fded65ee90f4384ebf2bcad
diff --git a/libpldmresponder/test/meson.build b/libpldmresponder/test/meson.build
index edb9643..d872fe7 100644
--- a/libpldmresponder/test/meson.build
+++ b/libpldmresponder/test/meson.build
@@ -12,7 +12,6 @@
'libpldmresponder_pdr_effecter_test',
'libpldmresponder_pdr_sensor_test',
]
-broken_tests = []
if get_option('oem-ibm').enabled()
@@ -20,9 +19,6 @@
'../../oem/ibm/test/libpldmresponder_fileio_test',
'../../oem/ibm/test/libpldmresponder_oem_platform_test'
]
- broken_tests += [
- '../../oem/ibm/test/libpldmresponder_oem_platform_test'
- ]
endif
dep_src_files = [
@@ -47,6 +43,5 @@
phosphor_dbus_interfaces,
sdeventplus,
sdbusplus]),
- should_fail: broken_tests.contains(t),
workdir: meson.current_source_dir())
endforeach
diff --git a/oem/ibm/test/libpldmresponder_oem_platform_test.cpp b/oem/ibm/test/libpldmresponder_oem_platform_test.cpp
index 5ad4fe2..614a09b 100644
--- a/oem/ibm/test/libpldmresponder_oem_platform_test.cpp
+++ b/oem/ibm/test/libpldmresponder_oem_platform_test.cpp
@@ -218,7 +218,7 @@
ASSERT_EQ(pdr->terminus_handle, TERMINUS_HANDLE);
ASSERT_EQ(pdr->entity_type, PLDM_OEM_IBM_ENTITY_FIRMWARE_UPDATE);
ASSERT_EQ(pdr->entity_instance, 0);
- ASSERT_EQ(pdr->container_id, 0);
+ ASSERT_EQ(pdr->container_id, 1);
ASSERT_EQ(pdr->effecter_semantic_id, 0);
ASSERT_EQ(pdr->effecter_init, PLDM_NO_INIT);
ASSERT_EQ(pdr->has_description_pdr, false);
@@ -245,7 +245,7 @@
ASSERT_EQ(pdr->terminus_handle, TERMINUS_HANDLE);
ASSERT_EQ(pdr->entity_type, PLDM_OEM_IBM_ENTITY_FIRMWARE_UPDATE);
ASSERT_EQ(pdr->entity_instance, 1);
- ASSERT_EQ(pdr->container_id, 0);
+ ASSERT_EQ(pdr->container_id, 1);
ASSERT_EQ(pdr->effecter_semantic_id, 0);
ASSERT_EQ(pdr->effecter_init, PLDM_NO_INIT);
ASSERT_EQ(pdr->has_description_pdr, false);
@@ -272,7 +272,7 @@
ASSERT_EQ(pdr->terminus_handle, TERMINUS_HANDLE);
ASSERT_EQ(pdr->entity_type, PLDM_OEM_IBM_ENTITY_FIRMWARE_UPDATE);
ASSERT_EQ(pdr->entity_instance, 0);
- ASSERT_EQ(pdr->container_id, 0);
+ ASSERT_EQ(pdr->container_id, 1);
ASSERT_EQ(pdr->effecter_semantic_id, 0);
ASSERT_EQ(pdr->effecter_init, PLDM_NO_INIT);
ASSERT_EQ(pdr->has_description_pdr, false);
@@ -323,7 +323,7 @@
ASSERT_EQ(pdr->terminus_handle, TERMINUS_HANDLE);
ASSERT_EQ(pdr->entity_type, PLDM_OEM_IBM_ENTITY_FIRMWARE_UPDATE);
ASSERT_EQ(pdr->entity_instance, 0);
- ASSERT_EQ(pdr->container_id, 0);
+ ASSERT_EQ(pdr->container_id, 1);
ASSERT_EQ(pdr->sensor_init, PLDM_NO_INIT);
ASSERT_EQ(pdr->sensor_auxiliary_names_pdr, false);
ASSERT_EQ(pdr->composite_sensor_count, 1);
@@ -349,7 +349,7 @@
ASSERT_EQ(pdr->terminus_handle, TERMINUS_HANDLE);
ASSERT_EQ(pdr->entity_type, PLDM_OEM_IBM_ENTITY_FIRMWARE_UPDATE);
ASSERT_EQ(pdr->entity_instance, 1);
- ASSERT_EQ(pdr->container_id, 0);
+ ASSERT_EQ(pdr->container_id, 1);
ASSERT_EQ(pdr->sensor_init, PLDM_NO_INIT);
ASSERT_EQ(pdr->sensor_auxiliary_names_pdr, false);
ASSERT_EQ(pdr->composite_sensor_count, 1);
@@ -375,7 +375,7 @@
ASSERT_EQ(pdr->terminus_handle, TERMINUS_HANDLE);
ASSERT_EQ(pdr->entity_type, PLDM_OEM_IBM_ENTITY_FIRMWARE_UPDATE);
ASSERT_EQ(pdr->entity_instance, 0);
- ASSERT_EQ(pdr->container_id, 0);
+ ASSERT_EQ(pdr->container_id, 1);
ASSERT_EQ(pdr->sensor_init, PLDM_NO_INIT);
ASSERT_EQ(pdr->sensor_auxiliary_names_pdr, false);
ASSERT_EQ(pdr->composite_sensor_count, 1);