oem-ibm: Fix the bios event message
bios event is an oem platform event message & as per the PLDM
platform spec DSP0248_1.2.0 (Table 15),the event message should have
that TID of the terminus that originated the event message, not the EID.
This commit would also remove unwanted tracing in the BIOS event
path.
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I7d7a9d1bc05ed2fc4869d61a44634436164edfc0
diff --git a/oem/ibm/libpldmresponder/platform_oem_ibm.cpp b/oem/ibm/libpldmresponder/platform_oem_ibm.cpp
index 7639e54..fbc7ba7 100644
--- a/oem/ibm/libpldmresponder/platform_oem_ibm.cpp
+++ b/oem/ibm/libpldmresponder/platform_oem_ibm.cpp
@@ -14,7 +14,6 @@
{
namespace platform
{
-
int sendBiosAttributeUpdateEvent(
uint8_t eid, dbus_api::Requester* requester,
const std::vector<uint16_t>& handles,
@@ -57,9 +56,8 @@
auto request = reinterpret_cast<pldm_msg*>(requestMsg.data());
auto rc = encode_bios_attribute_update_event_req(
- instanceId, PLDM_PLATFORM_EVENT_MESSAGE_FORMAT_VERSION,
- pldm::responder::pdr::BmcMctpEid, handles.size(),
- reinterpret_cast<const uint8_t*>(handles.data()),
+ instanceId, PLDM_PLATFORM_EVENT_MESSAGE_FORMAT_VERSION, TERMINUS_ID,
+ handles.size(), reinterpret_cast<const uint8_t*>(handles.data()),
requestMsg.size() - sizeof(pldm_msg_hdr), request);
if (rc != PLDM_SUCCESS)
{
@@ -69,17 +67,6 @@
return rc;
}
- if (requestMsg.size())
- {
- std::ostringstream tempStream;
- for (int byte : requestMsg)
- {
- tempStream << std::setfill('0') << std::setw(2) << std::hex << byte
- << " ";
- }
- std::cout << tempStream.str() << std::endl;
- }
-
auto platformEventMessageResponseHandler = [](mctp_eid_t /*eid*/,
const pldm_msg* response,
size_t respMsgLen) {