bios: Add support for enum value display names
This commits adds changes to add support for the value
display names for the Enum BIOS attributes.
GET on
/redfish/v1/Registries/BiosAttributeRegistry/BiosAttributeRegistry/
shows list of Attributes under RegistryEntries. Each
attribute corresponds to a knob in BIOS.
If knob in BIOS is of type Enumeration, it will have
'option' with 'text' and 'value'. This text should be
mapped to attribute->Value->ValueDisplayName.
This change only applies to ENUM type of BIOS attributes
and does not make sense for Integer and String attributes.
Hence, we are sending attribute name in place of the
value display name field for these attributes.
The corresponding bios-setting-mgr change which mandated
this change in PLDM is at-
[1] https://github.com/openbmc/bios-settings-mgr/commit/1a448ad88fdaec7e082b4a1c437f7f3c990402cd
Signed-off-by: Sagar Srinivas <sagar.srinivas@ibm.com>
Change-Id: Ib2882c93e81a70332e4897b196ae812b63cf6184
diff --git a/libpldmresponder/test/libpldmresponder_bios_enum_attribute_test.cpp b/libpldmresponder/test/libpldmresponder_bios_enum_attribute_test.cpp
index bb0f652..775cd15 100644
--- a/libpldmresponder/test/libpldmresponder_bios_enum_attribute_test.cpp
+++ b/libpldmresponder/test/libpldmresponder_bios_enum_attribute_test.cpp
@@ -37,6 +37,7 @@
auto jsonEnumReadOnly = R"({
"attribute_name" : "CodeUpdatePolicy",
"possible_values" : [ "Concurrent", "Disruptive" ],
+ "value_names" : [ "Concurrent", "Disruptive" ],
"default_values" : [ "Concurrent" ],
"readOnly" : true,
"helpText" : "HelpText",
@@ -53,6 +54,7 @@
auto jsonEnumReadOnlyError = R"({
"attribute_name" : "CodeUpdatePolicy",
"possible_value" : [ "Concurrent", "Disruptive" ],
+ "value_names" : [ "Concurrent", "Disruptive" ],
"default_values" : [ "Concurrent" ],
"readOnly" : true,
"helpText" : "HelpText",
@@ -64,6 +66,7 @@
auto jsonEnumReadWrite = R"({
"attribute_name" : "FWBootSide",
"possible_values" : [ "Perm", "Temp" ],
+ "value_names" : [ "Perm", "Temp" ],
"default_values" : [ "Perm" ],
"readOnly" : false,
"helpText" : "HelpText",
@@ -91,6 +94,7 @@
auto jsonEnumReadOnly = R"({
"attribute_name" : "CodeUpdatePolicy",
"possible_values" : [ "Concurrent", "Disruptive" ],
+ "value_names" : [ "Concurrent", "Disruptive" ],
"default_values" : [ "Disruptive" ],
"readOnly" : true,
"helpText" : "HelpText",
@@ -130,6 +134,7 @@
auto jsonEnumReadWrite = R"({
"attribute_name" : "CodeUpdatePolicy",
"possible_values" : [ "Concurrent", "Disruptive" ],
+ "value_names" : [ "Concurrent", "Disruptive" ],
"default_values" : [ "Disruptive" ],
"readOnly" : false,
"helpText" : "HelpText",
@@ -182,6 +187,7 @@
auto jsonEnumReadWrite = R"({
"attribute_name" : "CodeUpdatePolicy",
"possible_values" : [ "Concurrent", "Disruptive" ],
+ "value_names" : [ "Concurrent", "Disruptive" ],
"default_values" : [ "Disruptive" ],
"readOnly" : false,
"helpText" : "HelpText",