commit 7d47570cc26cae7721c4a839fa2bf936f9adb4d1
author Archana Kakani <archana.kakani@ibm.com> Wed May 22 08:30:27 2024 -0500
committer Archana Kakani <archana.kakani@ibm.com> Mon Jun 10 12:08:18 2024 +0000
tree 8d31d1bd0d918bfd7071928bd036860c82d2c358
parent ac713eec8b97954133fc500056fa394a6d7a7384

pldm: Removing default string length

Removing default string length from BIOS json configuration
files.

String BIOS attributes defined in BIOS configuration json file
contains "default_string_length". Providing default string length
manually is error prone. As String length can be calculated and
populated easily in the code, removing json support for
default_string_length.

Tested: Power on/off
        Gtests passed.

Change-Id: I7604d8ccedd60a39ba07e1df67ff5712f31e7f6e
Signed-off-by: Archana Kakani <archana.kakani@ibm.com>

libpldmresponder/test/libpldmresponder_bios_config_test.cpp

diff --git a/libpldmresponder/test/libpldmresponder_bios_config_test.cpp b/libpldmresponder/test/libpldmresponder_bios_config_test.cpp
index 6e7c57a..5c0e779 100644
--- a/libpldmresponder/test/libpldmresponder_bios_config_test.cpp
+++ b/libpldmresponder/test/libpldmresponder_bios_config_test.cpp
@@ -153,11 +153,10 @@
                 EXPECT_EQ(
                     stringField.maxLength,
                     jsonEntry->at("maximum_string_length").get<uint16_t>());
-                EXPECT_EQ(
-                    stringField.defLength,
-                    jsonEntry->at("default_string_length").get<uint16_t>());
                 EXPECT_EQ(stringField.defString,
                           jsonEntry->at("default_string").get<std::string>());
+                EXPECT_EQ(stringField.defLength,
+                          (stringField.defString).length());
                 break;
             }
             case PLDM_BIOS_INTEGER: