commit 81796c2ff1923be34fb58fb92e6dd350d533fa78
author John Wang <wangzqbj@inspur.com> Fri Sep 06 11:18:57 2019 +0800
committer John Wang <wangzqbj@inspur.com> Fri Sep 06 16:28:49 2019 +0800
tree 34ad6eb0c2c3f3350a2e6d5d29f616814f86e5ac
parent 4d844791887c776634ff27bca1dfd1313fe5413f

Fix issues in SetBiosAttributeCurrentValue in UT

Fixed some uninitialized variables and assigned
a more appropriate value to transferFlag in
in SetBiosAttributeCurrentValue in UT

Signed-off-by: John Wang <wangzqbj@inspur.com>
Change-Id: Id953b2d02ee4a179f7fb91263c9d4716ed847403

test/libpldm_bios_test.cpp

diff --git a/test/libpldm_bios_test.cpp b/test/libpldm_bios_test.cpp
index 0891142..46a75ed 100644
--- a/test/libpldm_bios_test.cpp
+++ b/test/libpldm_bios_test.cpp
@@ -334,8 +334,8 @@
 {
     uint8_t instanceId = 10;
     uint32_t transferHandle = 32;
-    uint8_t transferFlag = 8;
-    uint32_t attributeData;
+    uint8_t transferFlag = PLDM_START_AND_END;
+    uint32_t attributeData = 44;
     std::array<uint8_t, hdrSize + PLDM_SET_BIOS_ATTR_CURR_VAL_MIN_REQ_BYTES +
                             sizeof(attributeData)>
         requestMsg{};
@@ -360,8 +360,8 @@
 {
     uint8_t instanceId = 10;
     uint32_t transferHandle = 32;
-    uint8_t transferFlag = 8;
-    uint32_t attributeData;
+    uint8_t transferFlag = PLDM_START_AND_END;
+    uint32_t attributeData = 44;
     std::array<uint8_t, hdrSize + PLDM_SET_BIOS_ATTR_CURR_VAL_MIN_REQ_BYTES>
         requestMsg{};
     auto request = reinterpret_cast<pldm_msg*>(requestMsg.data());
@@ -380,8 +380,8 @@
 TEST(SetBiosAttributeCurrentValue, testGoodDecodeRequest)
 {
     uint32_t transferHandle = 32;
-    uint8_t transferFlag;
-    uint32_t attributeData;
+    uint8_t transferFlag = PLDM_START_AND_END;
+    uint32_t attributeData = 44;
 
     std::array<uint8_t, hdrSize + PLDM_SET_BIOS_ATTR_CURR_VAL_MIN_REQ_BYTES +
                             sizeof(attributeData)>
@@ -414,9 +414,9 @@
 TEST(SetBiosAttributeCurrentValue, testBadDecodeRequest)
 {
     uint32_t transferHandle = 32;
-    uint8_t transferFlag;
-    uint32_t attributeData;
-    size_t attributeDataLength;
+    uint8_t transferFlag = PLDM_START_AND_END;
+    uint32_t attributeData = 44;
+    size_t attributeDataLength = sizeof(attributeData);
     std::array<uint8_t, hdrSize + PLDM_SET_BIOS_ATTR_CURR_VAL_MIN_REQ_BYTES - 1>
         requestMsg{};
     auto request = reinterpret_cast<struct pldm_msg*>(requestMsg.data());
@@ -506,4 +506,4 @@
         &nextTransferHandle);
 
     ASSERT_EQ(rc, PLDM_ERROR_INVALID_LENGTH);
-}
\ No newline at end of file
+}