commit 82257922c1442d3bee1a3d2a42885c7e1d5908e3
author Sagar Srinivas <sagar.srinivas@ibm.com> Mon Jul 10 08:12:22 2023 -0500
committer Sagar Srinivas <sagar.srinivas@ibm.com> Wed Aug 02 23:10:34 2023 -0500
tree ddcb4ecc130f29497ebaf86885c7fc56354cb9b5
parent fc81a437dd13d97409ebebabcc3befd1832cfcf0

Enhance traces for File Size Exceeds Offset

This commit adds changes to enhance or give context
to the generic error traces related to errors for
file size exceeding file offset provided by remote
terminus.

Signed-off-by: Sagar Srinivas <sagar.srinivas@ibm.com>
Change-Id: Ic088a54190c2f990d07609a35c9b45bab637a15b

oem/ibm/libpldmresponder/file_io.cpp

diff --git a/oem/ibm/libpldmresponder/file_io.cpp b/oem/ibm/libpldmresponder/file_io.cpp
index c57c387..b01ef19 100644
--- a/oem/ibm/libpldmresponder/file_io.cpp
+++ b/oem/ibm/libpldmresponder/file_io.cpp
@@ -303,8 +303,9 @@
     auto fileSize = fs::file_size(value.fsPath);
     if (offset >= fileSize)
     {
-        error("Offset exceeds file size, OFFSET={OFFSTE} FILE_SIZE={FILE_SIZE}",
-              "OFFSET", offset, "FILE_SIZE", fileSize);
+        error(
+            "Offset exceeds file size, OFFSET={OFFSTE} FILE_SIZE={FILE_SIZE} FILE_HANDLE{FILE_HANDLE}",
+            "OFFSET", offset, "FILE_SIZE", fileSize, "FILE_HANDLE", fileHandle);
         encode_rw_file_memory_resp(request->hdr.instance_id,
                                    PLDM_READ_FILE_INTO_MEMORY,
                                    PLDM_DATA_OUT_OF_RANGE, 0, responsePtr);
@@ -397,8 +398,9 @@
     auto fileSize = fs::file_size(value.fsPath);
     if (offset >= fileSize)
     {
-        error("Offset exceeds file size, OFFSET={OFFSET} FILE_SIZE={FILE_SIZE}",
-              "OFFSET", offset, "FILE_SIZE", fileSize);
+        error(
+            "Offset exceeds file size, OFFSET={OFFSET} FILE_SIZE={FILE_SIZE} FILE_HANDLE{FILE_HANDLE}",
+            "OFFSET", offset, "FILE_SIZE", fileSize, "FILE_HANDLE", fileHandle);
         encode_rw_file_memory_resp(request->hdr.instance_id,
                                    PLDM_WRITE_FILE_FROM_MEMORY,
                                    PLDM_DATA_OUT_OF_RANGE, 0, responsePtr);