commit 88bc7183014345bc4b53d3395eb6f4fddd17b0ec
author Manojkiran Eda <manojkiran.eda@gmail.com> Wed Sep 08 18:37:30 2021 +0530
committer ManojKiran Eda <manojkiran.eda@gmail.com> Thu Sep 09 04:02:57 2021 +0000
tree 2e3d6a573b441b9afba07fc5c4dd237103004784
parent 0922275b3b575e4c8e70b837818b9d0a0afe9eac

Fix for discovering the HostState

- 20aa3e09fb866c1b99c1d3d702f2a2f1908558af commit moved the
  setHostFirmwarecondition() function call prior to the code
  that connects to the mctp socket.

- That led us to fail in sending the message with ENOTCONN Errno,
  as demonstrated by the below strace log.

------
23:16:50.596833 connect(3, {sa_family=AF_UNIX, sun_path=@"mctp-mux"}, 11) = 0

Change-Id: Icd3a20e4bb0218517d44d14a57c0407c7b7702e2
---
23:16:50.593800 sendmsg(3, {msg_name=NULL, msg_namelen=0, msg_iov=[{iov_base="\t\1",
 iov_len=2}, {iov_base="\200\0\3\0\0\0\0\1\0", iov_len=9}], msg_iovlen=2, msg_controllen=0,
 msg_flags=0}, 0) = -1 ENOTCONN
-----

- Without this change , we would get ENOTCONN(107 errono) for the
  getPLDMVersion command that pldm sends at the begining to discover the
  host state.

TestedBy:
1. when host is off :
Response not received for the request, instance ID expired. EID = 9 INSTANCE_ID = 0 TYPE = 0 COMMAND = 3
Failed to receive response for getPLDMVersion command, Host seems to be off

2. when host is Running :
Sending Msg
80 00 03 00 00 00 00 01 00
Received Msg
09 01 00 00 03 00 00 00 00 00 05 f1 f1 f0 00
Getting the response. PLDM RC = 0

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I5c7c3bc92c8654016db90855de49b7c30f161275

pldmd/pldmd.cpp

diff --git a/pldmd/pldmd.cpp b/pldmd/pldmd.cpp
index 1379c6e..63f13e1 100644
--- a/pldmd/pldmd.cpp
+++ b/pldmd/pldmd.cpp
@@ -250,10 +250,6 @@
     sdbusplus::xyz::openbmc_project::PLDM::server::Event dbusImplEvent(
         bus, "/xyz/openbmc_project/pldm");
 
-    if (hostPDRHandler)
-    {
-        hostPDRHandler->setHostFirmwareCondition();
-    }
 #endif
 
     pldm::utils::CustomFD socketFd(sockfd);
@@ -376,7 +372,12 @@
     bus.attach_event(event.get(), SD_EVENT_PRIORITY_NORMAL);
     bus.request_name("xyz.openbmc_project.PLDM");
     IO io(event, socketFd(), EPOLLIN, std::move(callback));
-
+#ifdef LIBPLDMRESPONDER
+    if (hostPDRHandler)
+    {
+        hostPDRHandler->setHostFirmwareCondition();
+    }
+#endif
     event.loop();
 
     result = shutdown(sockfd, SHUT_RDWR);