Fix GetBIOSAttributeCurrentValueByHandle
Add certain headers to the response as per table 14
from DSP0247_1.1.0
Tested: did the same test as this commit:
8721ed6e368cb7765b59b1a3821ad59d3cc1292b, saw the
headers were added.
GetBIOSAttributeCurrentValueByHandle handle = 0x02
root@fp5280g2:/tmp# pldmtool raw --data 0x80 0x03 0x08 0x00 0x00 0x00 0x00 0x00 0x02 0x00
Encode request successfully
Request Message:
08 01 80 03 08 00 00 00 00 00 02 00
Success in creating the socket : RC = 3
Success in connecting to socket : RC = 0
Success in sending message type as pldm to mctp : RC = 0
Write to socket successful : RC = 12
Total length:12
Loopback response message:
08 01 80 03 08 00 00 00 00 00 02 00
On first recv(),response == request : RC = 0
Total length: 16
Shutdown Socket successful : RC = 0
Response Message:
08 01 00 03 08 00 00 00 00 00 05 02 00 80 01 00
GetBIOSAttributeCurrentValueByHandle handle = 0x03
root@fp5280g2:/tmp# pldmtool raw --data 0x80 0x03 0x08 0x00 0x00 0x00 0x00 0x00 0x03 0x00
Encode request successfully
Request Message:
08 01 80 03 08 00 00 00 00 00 03 00
Success in creating the socket : RC = 3
Success in connecting to socket : RC = 0
Success in sending message type as pldm to mctp : RC = 0
Write to socket successful : RC = 12
Total length:12
Loopback response message:
08 01 80 03 08 00 00 00 00 00 03 00
On first recv(),response == request : RC = 0
Total length: 16
Shutdown Socket successful : RC = 0
Response Message:
08 01 00 03 08 00 00 00 00 00 05 03 00 80 01 01
GetBIOSAttributeCurrentValueByHandle handle = 0x06
root@fp5280g2:/tmp# pldmtool raw --data 0x80 0x03 0x08 0x00 0x00 0x00 0x00 0x00 0x06 0x00
Encode request successfully
Request Message:
08 01 80 03 08 00 00 00 00 00 06 00
Success in creating the socket : RC = 3
Success in connecting to socket : RC = 0
Success in sending message type as pldm to mctp : RC = 0
Write to socket successful : RC = 12
Total length:12
Loopback response message:
08 01 80 03 08 00 00 00 00 00 06 00
On first recv(),response == request : RC = 0
Total length: 6
Shutdown Socket successful : RC = 0
Response Message:
08 01 00 03 08 88
Signed-off-by: John Wang <wangzqbj@inspur.com>
Change-Id: If4456f7d73461e379a32d5a62f010e22565e8ad8
diff --git a/libpldm/bios_table.h b/libpldm/bios_table.h
index b1a7f51..8715bc7 100644
--- a/libpldm/bios_table.h
+++ b/libpldm/bios_table.h
@@ -524,18 +524,11 @@
uint16_t pldm_bios_table_attr_value_entry_decode_handle(
const struct pldm_bios_attr_val_table_entry *entry);
-/** @brief Get the value field length from the attribute value entry
+/** @brief Get the length of the attribute value entry
* @param[in] entry - Pointer to bios attribute value entry
- * @return Length of the value filed
+ * @return Length of the entry
*/
-size_t pldm_bios_table_attr_value_entry_value_length(
- const struct pldm_bios_attr_val_table_entry *entry);
-
-/** @brief Get the value field address from the attribute value entry
- * @param[in] entry - Pointer to bios attribute value entry
- * @return Pointer to the value field in the attribute value entry;
- */
-const uint8_t *pldm_bios_table_attr_value_entry_value(
+size_t pldm_bios_table_attr_value_entry_length(
const struct pldm_bios_attr_val_table_entry *entry);
/** @brief Find an entry in attribute value table by handle