commit 8fadc9e03fdb57e5e724df25134a96b27666a52d
author Manojkiran Eda <manojkiran.eda@gmail.com> Mon Jan 03 12:42:19 2022 +0530
committer ManojKiran Eda <manojkiran.eda@gmail.com> Wed Jan 05 01:24:27 2022 +0000
tree 03d9e349f769a7cb3ebf1382355f47f6b3f24138
parent 999999156ad75f225da964153808dac83589878f

pldmtool: Fix tool to show the oem entities

START & END are meant to be used as range to figure out if an
entity/state_set is OEM or not.They are not entity & state set
names.

This commit fixes above mentioned issue & also removes TPM entity
from the common fru_master configuration as the entity type is in
OEM range as per DSP0249_1.1.0 specification.

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: Iba4fadabf1ae4f94cee8f2f47632731de0bfd85f

configurations/fru_master.json

diff --git a/configurations/fru_master.json b/configurations/fru_master.json
index 5a87eb7..92f3843 100644
--- a/configurations/fru_master.json
+++ b/configurations/fru_master.json
@@ -15,7 +15,6 @@
                         "xyz.openbmc_project.Inventory.Item.Bmc": 137,
                         "xyz.openbmc_project.Inventory.Item.Connector": 185,
                         "xyz.openbmc_project.Inventory.Item.PCIeSlot": 186,
-                        "xyz.openbmc_project.Inventory.Item.System": 11521,
-                        "xyz.openbmc_project.Inventory.Item.Tpm": 24576
+                        "xyz.openbmc_project.Inventory.Item.System": 11521
            }
 }

oem/ibm/libpldm/entity_oem_ibm.h

diff --git a/oem/ibm/libpldm/entity_oem_ibm.h b/oem/ibm/libpldm/entity_oem_ibm.h
index 636167b..dd80f56 100644
--- a/oem/ibm/libpldm/entity_oem_ibm.h
+++ b/oem/ibm/libpldm/entity_oem_ibm.h
@@ -6,6 +6,7 @@
 #endif
 
 enum pldm_oem_ibm_entity_id_codes {
+	PLDM_OEM_IBM_ENTITY_TPM = 24576,
 	PLDM_OEM_IBM_ENTITY_FIRMWARE_UPDATE = 24577,
 };
 

pldmtool/oem/ibm/oem_ibm_state_set.hpp

diff --git a/pldmtool/oem/ibm/oem_ibm_state_set.hpp b/pldmtool/oem/ibm/oem_ibm_state_set.hpp
index 25045b5..d69e2fc 100644
--- a/pldmtool/oem/ibm/oem_ibm_state_set.hpp
+++ b/pldmtool/oem/ibm/oem_ibm_state_set.hpp
@@ -3,15 +3,6 @@
 #include <libpldm/entity.h>
 #include <libpldm/entity_oem_ibm.h>
 
-/** @brief PLDM OEM State Set range as per DSP0249_1.1.0 specification
- */
-enum pldm_oem_state_set_id_codes
-{
-    PLDM_OEM_STATE_SET_START = 32768,
-    PLDM_OEM_STATE_SET_END = 65535,
-
-};
-
 /** @brief PLDM OEM IBM Code Update possible state set values
  */
 enum pldm_oem_ibm_cu_state_set_values
@@ -53,9 +44,7 @@
  */
 extern const std::map<uint8_t, std::string> OemIBMEntityType{
     {PLDM_OEM_IBM_ENTITY_FIRMWARE_UPDATE, "OEM IBM Firmware Update"},
-    {PLDM_OEM_ENTITY_TYPE_START, "OEM IBM Entity Type Start"},
-    {PLDM_OEM_ENTITY_TYPE_END, "OEM IBM Entity Type End"},
-};
+    {PLDM_OEM_IBM_ENTITY_TPM, "OEM IBM Trusted Platform Module"}};
 
 /** @brief Map for PLDM OEM IBM State Sets
  */