commit 952abfac3cbb57c65da7e199c3ebcbd319ee3fef
author Tom Joseph <tomjoseph@in.ibm.com> Fri Jul 03 12:25:15 2020 +0530
committer Deepak Kodihalli <dkodihal@in.ibm.com> Tue Jul 07 12:40:16 2020 +0000
tree 502845a124c237b77da4d0babf790a769fc05045
parent c4e80ccaf2c8014fb0df9bd48027942a4877d889

pldmtool: Refactor the code for tracing the PDR header

Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
Change-Id: I88aa3f7a3b98a9218131f58c6bfe48cd71db7ab7

pldmtool/pldm_platform_cmd.cpp

diff --git a/pldmtool/pldm_platform_cmd.cpp b/pldmtool/pldm_platform_cmd.cpp
index 2c62f42..8cd15c0 100644
--- a/pldmtool/pldm_platform_cmd.cpp
+++ b/pldmtool/pldm_platform_cmd.cpp
@@ -103,6 +103,17 @@
         }
     }
 
+    void printCommonPDRHeader(const pldm_pdr_hdr* hdr)
+    {
+        std::cout << "recordHandle: " << hdr->record_handle << std::endl;
+        std::cout << "PDRHeaderVersion: " << unsigned(hdr->version)
+                  << std::endl;
+        std::cout << "PDRType: " << unsigned(hdr->type) << std::endl;
+        std::cout << "recordChangeNumber: " << hdr->record_change_num
+                  << std::endl;
+        std::cout << "dataLength: " << hdr->length << std::endl << std::endl;
+    }
+
     void printPDRFruRecordSet(uint8_t* data)
     {
         if (data == NULL)
@@ -171,22 +182,10 @@
         }
     }
 
-    void printEffecterHdrPDR(pldm_pdr_hdr* hdr)
-    {
-        std::cout << "recordHandle: " << hdr->record_handle << std::endl;
-        std::cout << "PDRHeaderVersion: " << unsigned(hdr->version)
-                  << std::endl;
-        std::cout << "PDRType: " << unsigned(hdr->type) << std::endl;
-        std::cout << "recordChangeNumber: " << hdr->record_change_num
-                  << std::endl;
-        std::cout << "dataLength: " << hdr->length << std::endl;
-    }
-
     void printNumericEffecterPDR(uint8_t* data)
     {
         struct pldm_numeric_effecter_value_pdr* pdr =
             (struct pldm_numeric_effecter_value_pdr*)data;
-        printEffecterHdrPDR(&pdr->hdr);
         std::cout << "PLDMTerminusHandle: " << pdr->terminus_handle
                   << std::endl;
         std::cout << "effecterID: " << pdr->effecter_id << std::endl;
@@ -375,7 +374,6 @@
 
         struct pldm_state_effecter_pdr* pdr =
             (struct pldm_state_effecter_pdr*)data;
-        printEffecterHdrPDR(&pdr->hdr);
 
         std::cout << "PLDMTerminusHandle: " << pdr->terminus_handle
                   << std::endl;
@@ -419,14 +417,7 @@
         std::cout << "responseCount: " << respCnt << std::endl;
 
         struct pldm_pdr_hdr* pdr = (struct pldm_pdr_hdr*)data;
-        std::cout << "recordHandle: " << pdr->record_handle << std::endl;
-        std::cout << "PDRHeaderVersion: " << unsigned(pdr->version)
-                  << std::endl;
-        std::cout << "PDRType: " << unsigned(pdr->type) << std::endl;
-        std::cout << "recordChangeNumber: " << pdr->record_change_num
-                  << std::endl;
-        std::cout << "dataLength: " << pdr->length << std::endl << std::endl;
-
+        printCommonPDRHeader(pdr);
         switch (pdr->type)
         {
             case PLDM_NUMERIC_EFFECTER_PDR: