commit | 96af8cb2c4438070e8c64cd00f0bfd67040c549d | [log] [tgz] |
---|---|---|
author | George Liu <liuxiwei@inspur.com> | Sat Jul 31 15:23:45 2021 +0800 |
committer | ManojKiran Eda <manojkiran.eda@gmail.com> | Fri Oct 20 06:24:04 2023 +0000 |
tree | e8405befbae7dca5045294e3914d4e309d0dcbab | |
parent | b75202e5b7fea81e678fa258a3c207b4349500a4 [diff] |
Normalize fru record set and PDRs from Remote terminus When Remote terminus sends the entity association PDR to BMC, BMC will generate a new container Id and put it into Remote terminus entity association PDR, and then add it to BMC entity association tree. As the container Id in the corresponding Remote terminus fru record set PDR and state sensor/effecter PDR has not been updated, when we get a fru record set PDR or state sensor/effecter PDR, we will check the entity association tree, pick up the changed container Id and update the fru record and add to our PDR repo. As per the Spec DSP 0248, Section 11.8 - <Designing Association PDRs for Monitoring and Control>, https://www.dmtf.org/sites/default/files/standards/documents/DSP0248_1.0.1.pdf 1) Identify the physical entities and assign them Entity Identification Information values: a) Identify the topmost physical container entities and give them the containerID for "system". b) Assign each remaining physical entity a different containerID value using whatever approach works best for the implementation. (For example, containerID values could be assigned sequentially starting from 1, or 1000 if it necessary to have a value that is more readily distinguishable as a being a containerID.) 2) Create Entity Association PDRs for the physical-to-physical containment associations. 3) Create the Sensor PDR, Effecter PDR, or other PDRs that are associated with the physical entities, and set the Entity Identification Information based on the containment PDRs that were created earlier. 4) Create the PDRs for any logical entities and set the containerID value for the containing entity to the containerID for the appropriate physical container entities. 5) Create the Sensor PDR, Effecter PDR, or other PDRs that reference those logical entities. We are following this principal in our change for Normalization of the PDRs from the remote Terminus. Signed-off-by: George Liu <liuxiwei@inspur.com> Change-Id: I48cab631ab4a50a8ba654c114792993cb5f418a7
Need meson
and ninja
. Alternatively, source an OpenBMC ARM/x86 SDK.
meson setup build && ninja -C build
The simplest way of running the tests is as described by the meson man page:
meson setup builddir && meson setup test -C builddir
Alternatively, tests can be run in the OpenBMC CI docker container, or with an OpenBMC x86 sdk(see below for x86 steps).
meson setup -Doe-sdk=enabled build ninja -C build test
pldm daemon accepts a command line argument --verbose
or --v
or -v
to enable the daemon to run in verbose mode. It can be done via adding this option to the environment file that pldm service consumes.
echo 'PLDMD_ARGS="--verbose"' > /etc/default/pldmd systemctl restart pldmd
rm /etc/default/pldmd systemctl restart pldmd
At a high-level, code in this repository belongs to one of the following three components.
This library provides handlers for incoming PLDM request messages. It provides for a registration as well as a plug-in mechanism. The library is implemented in modern C++, and handles OpenBMC's platform specifics.
The handlers are of the form
Response handler(Request payload, size_t payloadLen)
Source files are named according to the PLDM Type, for eg base.[hpp/cpp], fru.[hpp/cpp], etc.
This will support OEM or vendor-specific functions and semantic information. Following directory structure has to be used:
pldm repo |---- oem |----<oem_name> |----libpldmresponder |---<oem based handler files>
<oem_name> - This folder must be created with the name of the OEM/vendor in lower case. Folders named libpldm and libpldmresponder must be created under the folder <oem_name>
Files having the oem functionality for the libpldmresponder library should be placed under the folder oem/<oem_name>/libpldmresponder. They must be adhering to the rules mentioned under the libpldmresponder section above.
Once the above is done a meson option has to be created in pldm/meson_options.txt
with its mapped compiler flag to enable conditional compilation.
For consistency would recommend using "oem-<oem_name>".
The pldm/meson.build
and the corresponding source file(s) will need to incorporate the logic of adding its mapped compiler flag to allow conditional compilation of the code.
pldm daemon links against the libpldm library during compilation, For more information on libpldm please refer to libpldm
For more information on pldmtool please refer to plmdtool/README.md.
This section documents important code flow paths.
a) PLDM daemon receives PLDM request message from underlying transport (MCTP).
b) PLDM daemon routes message to message handler, based on the PLDM command.
c) Message handler decodes request payload into various field(s) of the request message. It can make use of a decode_foo_req() API, and doesn't have to perform deserialization of the request payload by itself.
d) Message handler works with the request field(s) and generates response field(s).
e) Message handler prepares a response message. It can make use of an encode_foo_resp() API, and doesn't have to perform the serialization of the response field(s) by itself.
f) The PLDM daemon sends the response message prepared at step e) to the remote PLDM device.
a) A BMC PLDM requester app prepares a PLDM request message. There would be several requester apps (based on functionality/PLDM remote device). Each of them needn't bother with the serialization of request field(s), and can instead make use of an encode_foo_req() API.
b) BMC requester app requests PLDM daemon to send the request message to remote PLDM device.
c) Once the PLDM daemon receives a corresponding response message, it notifies the requester app.
d) The requester app has to work with the response field(s). It can make use of a decode_foo_resp() API to deserialize the response message.
While PLDM Platform Descriptor Records (PDRs) are mostly static information, they can vary across platforms and systems. For this reason, platform specific PDR information is encoded in platform specific JSON files. JSON files must be named based on the PDR type number. For example a state effecter PDR JSON file will be named 11.json. The JSON files may also include information to enable additional processing (apart from PDR creation) for specific PDR types, for eg mapping an effecter id to a D-Bus object.
The PLDM responder implementation finds and parses PDR JSON files to create the PDR repository. Platform specific PDR modifications would likely just result in JSON updates. New PDR type support would require JSON updates as well as PDR generation code. The PDR generator is a map of PDR Type -> C++ lambda to create PDR entries for that type based on the JSON, and to update the central PDR repo.