commit aa8ae72f3fffbaba4d7fde02b722d92be836a649
author Sampa Misra <sampmisr@in.ibm.com> Thu Dec 12 03:20:40 2019 -0600
committer Deepak Kodihalli <dkodihal@in.ibm.com> Sun Jan 12 22:57:00 2020 -0600
tree bf9800cc511ff0498ceac514cb45541973c9aa0d
parent 08efc7b35d2dd6c79674ef48d42784113f081a17

remove phosphor-logging dependency

This commit removes pldm's dependency on phosphor-logging
and instead uses stdout and stdcerr for logging purpose.This is to
break the build time circular dependency between pldm and
phosphor-logging.

Change-Id: I8cffa3c99eb34efad5f186b3452a86ebadec2074
Signed-off-by: Sampa Misra <sampmisr@in.ibm.com>

test/libpldmresponder_pdr_state_effecter_test.cpp

diff --git a/test/libpldmresponder_pdr_state_effecter_test.cpp b/test/libpldmresponder_pdr_state_effecter_test.cpp
index c55feb0..e758f63 100644
--- a/test/libpldmresponder_pdr_state_effecter_test.cpp
+++ b/test/libpldmresponder_pdr_state_effecter_test.cpp
@@ -103,5 +103,7 @@
     Repo& pdrRepo = get("./pdr_jsons/state_effecter/good");
     ASSERT_EQ(pdrRepo.numEntries(), 2);
     pdrRepo.makeEmpty();
-    ASSERT_THROW(get("./pdr_jsons/state_effecter/malformed"), std::exception);
+    ASSERT_THROW(pldm::responder::pdr::internal::readJson(
+                     "./pdr_jsons/state_effecter/malformed"),
+                 std::exception);
 }

test/libpldmresponder_platform_test.cpp

diff --git a/test/libpldmresponder_platform_test.cpp b/test/libpldmresponder_platform_test.cpp
index 88a6eb4..208edc3 100644
--- a/test/libpldmresponder_platform_test.cpp
+++ b/test/libpldmresponder_platform_test.cpp
@@ -160,13 +160,13 @@
                  sizeof(uint16_t);
         pldm_pdr_hdr* hdr = reinterpret_cast<pldm_pdr_hdr*>(start);
         uint32_t intType = hdr->type;
-        std::cerr << "PDR next record handle " << handle << std::endl;
-        std::cerr << "PDR type " << intType << std::endl;
+        std::cerr << "PDR next record handle " << handle << "\n";
+        std::cerr << "PDR type " << intType << "\n";
         if (hdr->type == PLDM_STATE_EFFECTER_PDR)
         {
             pldm_state_effecter_pdr* pdr =
                 reinterpret_cast<pldm_state_effecter_pdr*>(start);
-            std::cerr << "PDR entity type " << pdr->entity_type << std::endl;
+            std::cerr << "PDR entity type " << pdr->entity_type << "\n";
             if (pdr->entity_type == 100)
             {
                 found = true;

test/meson.build

diff --git a/test/meson.build b/test/meson.build
index 4019cde..a9cdd94 100644
--- a/test/meson.build
+++ b/test/meson.build
@@ -51,7 +51,6 @@
                          gmock,
                          pldmd,
                          dependency('phosphor-dbus-interfaces'),
-                         dependency('phosphor-logging'),
                          dependency('sdbusplus')]),
        workdir: meson.current_source_dir())
 endforeach