commit b4e8cfde8021000c24b6bfd90d2a3aef57188955
author Thu Nguyen <thu@os.amperecomputing.com> Thu Mar 23 15:06:44 2023 +0700
committer ThuBaNguyen <thu@os.amperecomputing.com> Thu May 25 05:45:53 2023 +0700
tree 5375ab93fefb4c6703707e4a69d1a93b2a2872c7
parent a330b2f074b8d552143fe62c2d1843857c12637f

requester: Check duplicate key when call registerRequest

Add checking the existing of key {eid, instanceId, type, command}
when call registerRequest.

Tested:
1. Stress polling PLDM sensors.
2. Call pldmtool command to get sensor quickly.
3. Check message "The eid:InstanceID <eid>:<InstanceID> is using."

Change-Id: Ib547eb56e738a7aebfe87ce4967ebf1694e5b3ee
Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>

requester/handler.hpp

diff --git a/requester/handler.hpp b/requester/handler.hpp
index 9fa5c31..727adf9 100644
--- a/requester/handler.hpp
+++ b/requester/handler.hpp
@@ -165,6 +165,13 @@
             }
         };
 
+        if (handlers.contains(key))
+        {
+            error("The eid:InstanceID {EID}:{IID} is using.", "EID",
+                  (unsigned)eid, "IID", (unsigned)instanceId);
+            return PLDM_ERROR;
+        }
+
         auto request = std::make_unique<RequestInterface>(
             fd, eid, event, std::move(requestMsg), numRetries, responseTimeOut,
             currentSendbuffSize, verbose);