commit b6333cbdaae26ab0909de5b5dfb76f8428488f73
author John Wang <wangzqbj@inspur.com> Tue Dec 10 09:43:42 2019 +0800
committer Deepak Kodihalli <dkodihal@in.ibm.com> Tue Jan 07 05:46:45 2020 -0600
tree 4d6bc4f1f7b8172bb3be2a7cbd791b5fd1f48a90
parent 49484a1ad4855766aaa0771a908c41711e398600

libpldm: bios_table: Make auxiliary handlers const

The handler for calculating the entry length is registered
statically, and it is more appropriate to declare it as const

Signed-off-by: John Wang <wangzqbj@inspur.com>
Change-Id: Iff78d913eb131315c1859754463dea73652f49f0

libpldm/bios_table.c

diff --git a/libpldm/bios_table.c b/libpldm/bios_table.c
index 8a6e29a..1b98c1d 100644
--- a/libpldm/bios_table.c
+++ b/libpldm/bios_table.c
@@ -480,8 +480,8 @@
 
 #define ARRAY_SIZE(a) (sizeof(a) / sizeof(a[0]))
 
-static struct table_entry_length *find_table_entry_length_by_type(
-    uint8_t attr_type, struct table_entry_length *handlers, size_t count)
+static const struct table_entry_length *find_table_entry_length_by_type(
+    uint8_t attr_type, const struct table_entry_length *handlers, size_t count)
 {
 	size_t i;
 	for (i = 0; i < count; i++) {
@@ -491,7 +491,7 @@
 	return NULL;
 }
 
-static struct table_entry_length attr_table_entries[] = {
+static const struct table_entry_length attr_table_entries[] = {
     {.attr_type = PLDM_BIOS_ENUMERATION,
      .entry_length_handler = attr_table_entry_length_enum},
     {.attr_type = PLDM_BIOS_ENUMERATION_READ_ONLY,
@@ -509,7 +509,7 @@
 static size_t attr_table_entry_length(const void *table_entry)
 {
 	const struct pldm_bios_attr_table_entry *entry = table_entry;
-	struct table_entry_length *attr_table_entry =
+	const struct table_entry_length *attr_table_entry =
 	    find_table_entry_length_by_type(entry->attr_type,
 					    attr_table_entries,
 					    ARRAY_SIZE(attr_table_entries));
@@ -671,7 +671,7 @@
 	return pldm_bios_table_attr_value_entry_encode_integer_length();
 }
 
-static struct table_entry_length attr_value_table_entries[] = {
+static const struct table_entry_length attr_value_table_entries[] = {
     {.attr_type = PLDM_BIOS_ENUMERATION,
      .entry_length_handler = attr_value_table_entry_length_enum},
     {.attr_type = PLDM_BIOS_ENUMERATION_READ_ONLY,
@@ -689,7 +689,7 @@
 static size_t attr_value_table_entry_length(const void *table_entry)
 {
 	const struct pldm_bios_attr_val_table_entry *entry = table_entry;
-	struct table_entry_length *entry_length =
+	const struct table_entry_length *entry_length =
 	    find_table_entry_length_by_type(
 		entry->attr_type, attr_value_table_entries,
 		ARRAY_SIZE(attr_value_table_entries));