commit bd5e2eaa4316492673642b45cbaa832d675e5e19
author George Liu <liuxiwei@inspur.com> Thu Apr 22 20:33:06 2021 +0800
committer George Liu <liuxiwei@inspur.com> Tue Apr 27 01:20:31 2021 +0000
tree e95e0e75eade575e73359495e96a9b918a63d9d0
parent a66f2e9d7922c0b561bedfc4f3b6a288c57b153f

Fix potential map::at error

There are some potential errors, when using the map::at method,
the process may hang due to out of bounds. so the exception should
be caught.

Also, use the map::contains method of C++20 instead of map::find.

Tested: built pldm successfully and worked.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ia5d7dea906e5c598072c08b27387195ef1201839

libpldmresponder/platform_state_effecter.hpp

diff --git a/libpldmresponder/platform_state_effecter.hpp b/libpldmresponder/platform_state_effecter.hpp
index ba1c9bd..5875f13 100644
--- a/libpldmresponder/platform_state_effecter.hpp
+++ b/libpldmresponder/platform_state_effecter.hpp
@@ -143,8 +143,8 @@
     }
     catch (const std::out_of_range& e)
     {
-        std::cerr << "the effecterId does not exist. effecter id: "
-                  << effecterId << e.what() << '\n';
+        std::cerr << "Unknown effecter ID : " << effecterId << e.what() << '\n';
+        return PLDM_ERROR;
     }
 
     return rc;