implement async handlers for all requester commands
this commit makes use of 74f27c730ef3925a0f2a3adfaa04f8790f931372 to
convert the existing blocking requester commands in pldm to async
ones.
this is tested with Host code and seems to work fine
Change-Id: I8d4762c3cd5bce49f854b30f8325bfcd1dcb4ff9
Signed-off-by: Sampa Misra <sampmisr@in.ibm.com>
diff --git a/host-bmc/dbus_to_host_effecters.cpp b/host-bmc/dbus_to_host_effecters.cpp
index 4bdeda5..6dff8af 100644
--- a/host-bmc/dbus_to_host_effecters.cpp
+++ b/host-bmc/dbus_to_host_effecters.cpp
@@ -280,42 +280,40 @@
std::cout << tempStream.str() << std::endl;
}
}
+ auto setStateEffecterStatesRespHandler =
+ [](mctp_eid_t /*eid*/, const pldm_msg* response, size_t respMsgLen) {
+ if (response == nullptr || !respMsgLen)
+ {
+ std::cerr << "Failed to receive response for "
+ << "setStateEffecterStates command \n";
+ return;
+ }
+ uint8_t completionCode{};
+ auto rc = decode_set_state_effecter_states_resp(
+ response, respMsgLen, &completionCode);
+ if (rc)
+ {
+ std::cerr << "Failed to decode setStateEffecterStates response,"
+ << " rc " << rc << "\n";
+ pldm::utils::reportError(
+ "xyz.openbmc_project.bmc.pldm.SetHostEffecterFailed");
+ }
+ if (completionCode)
+ {
+ std::cerr << "Failed to set a Host effecter "
+ << ", cc=" << static_cast<unsigned>(completionCode)
+ << "\n";
+ pldm::utils::reportError(
+ "xyz.openbmc_project.bmc.pldm.SetHostEffecterFailed");
+ }
+ };
- uint8_t* responseMsg = nullptr;
- size_t responseMsgSize{};
-
- rc = pldm_send_recv(mctpEid, sockFd, requestMsg.data(), requestMsg.size(),
- &responseMsg, &responseMsgSize);
- std::unique_ptr<uint8_t, decltype(std::free)*> responseMsgPtr{responseMsg,
- std::free};
- requester->markFree(mctpEid, instanceId);
-
- if (rc != PLDM_REQUESTER_SUCCESS)
+ rc = handler->registerRequest(
+ mctpEid, instanceId, PLDM_PLATFORM, PLDM_SET_STATE_EFFECTER_STATES,
+ std::move(requestMsg), std::move(setStateEffecterStatesRespHandler));
+ if (rc)
{
- std::cerr << "Failed to send message/receive response. RC = " << rc
- << ", errno = " << errno << " for setting host effecter "
- << effecterId << "\n";
- pldm::utils::reportError(
- "xyz.openbmc_project.bmc.pldm.InternalFailure");
- return rc;
- }
- auto responsePtr = reinterpret_cast<struct pldm_msg*>(responseMsgPtr.get());
- uint8_t completionCode{};
- rc = decode_set_state_effecter_states_resp(
- responsePtr, responseMsgSize - sizeof(pldm_msg_hdr), &completionCode);
- if (rc != PLDM_SUCCESS)
- {
- std::cerr << "Failed to decode setStateEffecterStates response, rc = "
- << rc << "\n";
- return rc;
- }
- if (completionCode != PLDM_SUCCESS)
- {
- std::cerr << "Failed setStateEffecterStates for effecter " << effecterId
- << ". Response from Host " << (uint32_t)completionCode
- << "\n";
- pldm::utils::reportError(
- "xyz.openbmc_project.bmc.pldm.InternalFailure");
+ std::cerr << "Failed to send request to set an effecter on Host \n";
}
return rc;
}