commit c14fb4bdd42fc65b68d43e1295d36a9d2408ab8b
author Andrew Jeffery <andrew@codeconstruct.com.au> Thu Jul 25 22:13:09 2024 +0930
committer Andrew Jeffery <andrew@codeconstruct.com.au> Mon Jul 29 00:13:26 2024 +0930
tree 2e67a629f1c520f6734e46de5390669a89654ba0
parent 78dd846bcbc543c1c5be76911b2226b3c2f211d7

pldm: Drop pessimizing moves

Fixes issues such as:

```
../host-bmc/host_pdr_handler.cpp:684:9: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move]
  684 |         std::move(std::vector<uint8_t>(1, PLDM_PDR_ENTITY_ASSOCIATION)),
      |         ^
../host-bmc/host_pdr_handler.cpp:684:9: note: remove std::move call here
  684 |         std::move(std::vector<uint8_t>(1, PLDM_PDR_ENTITY_ASSOCIATION)),
      |         ^~~~~~~~~~                                                    ~
```

Change-Id: Id26f0d6fc21837e1eb76ae3c294c222782a4e69f
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

host-bmc/host_pdr_handler.cpp

diff --git a/host-bmc/host_pdr_handler.cpp b/host-bmc/host_pdr_handler.cpp
index 3621f92..dee768e 100644
--- a/host-bmc/host_pdr_handler.cpp
+++ b/host-bmc/host_pdr_handler.cpp
@@ -194,7 +194,7 @@
     rc = handler->registerRequest(
         mctp_eid, instanceId, PLDM_PLATFORM, PLDM_GET_PDR,
         std::move(requestMsg),
-        std::move(std::bind_front(&HostPDRHandler::processHostPDRs, this)));
+        std::bind_front(&HostPDRHandler::processHostPDRs, this));
     if (rc)
     {
         error(
@@ -679,7 +679,7 @@
 {
     deferredPDRRepoChgEvent.reset();
     this->sendPDRRepositoryChgEvent(
-        std::move(std::vector<uint8_t>(1, PLDM_PDR_ENTITY_ASSOCIATION)),
+        std::vector<uint8_t>(1, PLDM_PDR_ENTITY_ASSOCIATION),
         FORMAT_IS_PDR_HANDLES);
 }