commit c14fb4bdd42fc65b68d43e1295d36a9d2408ab8b
author Andrew Jeffery <andrew@codeconstruct.com.au> Thu Jul 25 22:13:09 2024 +0930
committer Andrew Jeffery <andrew@codeconstruct.com.au> Mon Jul 29 00:13:26 2024 +0930
tree 2e67a629f1c520f6734e46de5390669a89654ba0
parent 78dd846bcbc543c1c5be76911b2226b3c2f211d7

pldm: Drop pessimizing moves

Fixes issues such as:

```
../host-bmc/host_pdr_handler.cpp:684:9: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move]
  684 |         std::move(std::vector<uint8_t>(1, PLDM_PDR_ENTITY_ASSOCIATION)),
      |         ^
../host-bmc/host_pdr_handler.cpp:684:9: note: remove std::move call here
  684 |         std::move(std::vector<uint8_t>(1, PLDM_PDR_ENTITY_ASSOCIATION)),
      |         ^~~~~~~~~~                                                    ~
```

Change-Id: Id26f0d6fc21837e1eb76ae3c294c222782a4e69f
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

oem/ibm/libpldmresponder/file_table.cpp

diff --git a/oem/ibm/libpldmresponder/file_table.cpp b/oem/ibm/libpldmresponder/file_table.cpp
index d0b06bc..d91c482 100644
--- a/oem/ibm/libpldmresponder/file_table.cpp
+++ b/oem/ibm/libpldmresponder/file_table.cpp
@@ -134,7 +134,7 @@
     static FileTable table;
     if (table.isEmpty())
     {
-        table = std::move(FileTable(fileTablePath));
+        table = FileTable(fileTablePath);
     }
     return table;
 }