libpldmresponder: pldm_bios_table_append_pad_checksum() is deprecated
Migrate to pldm_bios_table_append_pad_checksum_check() which does not
sanitize its behaviour with assert().
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ide288bb40e5acabd2bf85870849bf176ddcbc621
diff --git a/libpldmresponder/bios_table.cpp b/libpldmresponder/bios_table.cpp
index f29d813..f4fcecf 100644
--- a/libpldmresponder/bios_table.cpp
+++ b/libpldmresponder/bios_table.cpp
@@ -81,12 +81,11 @@
{
void appendPadAndChecksum(Table& table)
{
- auto sizeWithoutPad = table.size();
- auto padAndChecksumSize = pldm_bios_table_pad_checksum_size(sizeWithoutPad);
- table.resize(table.size() + padAndChecksumSize);
-
- pldm_bios_table_append_pad_checksum(table.data(), table.size(),
- sizeWithoutPad);
+ size_t payloadSize = table.size();
+ table.resize(payloadSize + pldm_bios_table_pad_checksum_size(payloadSize));
+ // No validation of return value as preconditions are satisfied
+ pldm_bios_table_append_pad_checksum_check(table.data(), table.size(),
+ &payloadSize);
}
namespace string