libpldm: Correct reference to libpldm header files
When relying on header files from external libraries, #include<> should
be used instead of #include "" to avoid ambiguity.
Tested: Built pldm successfully after enabling ibm-oem
Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ia1997de7e0f61564055bbd837f4e24c8f14e55a5
diff --git a/oem/ibm/libpldmresponder/file_io.cpp b/oem/ibm/libpldmresponder/file_io.cpp
index b347960..acf9d4a 100644
--- a/oem/ibm/libpldmresponder/file_io.cpp
+++ b/oem/ibm/libpldmresponder/file_io.cpp
@@ -2,14 +2,13 @@
#include "file_io.hpp"
-#include "libpldm/base.h"
-
#include "file_io_by_type.hpp"
#include "file_table.hpp"
#include "utils.hpp"
#include "xyz/openbmc_project/Common/error.hpp"
#include <fcntl.h>
+#include <libpldm/base.h>
#include <sys/mman.h>
#include <sys/stat.h>
#include <sys/types.h>
diff --git a/oem/ibm/libpldmresponder/file_io.hpp b/oem/ibm/libpldmresponder/file_io.hpp
index 4c74463..769e716 100644
--- a/oem/ibm/libpldmresponder/file_io.hpp
+++ b/oem/ibm/libpldmresponder/file_io.hpp
@@ -2,10 +2,6 @@
#include "config.h"
-#include "libpldm/base.h"
-#include "libpldm/file_io.h"
-#include "libpldm/host.h"
-
#include "common/utils.hpp"
#include "oem/ibm/requester/dbus_to_file_handler.hpp"
#include "oem_ibm_handler.hpp"
@@ -13,6 +9,9 @@
#include "requester/handler.hpp"
#include <fcntl.h>
+#include <libpldm/base.h>
+#include <libpldm/file_io.h>
+#include <libpldm/host.h>
#include <stdint.h>
#include <sys/stat.h>
#include <sys/types.h>
diff --git a/oem/ibm/libpldmresponder/file_io_by_type.cpp b/oem/ibm/libpldmresponder/file_io_by_type.cpp
index c465c0d..dc575d2 100644
--- a/oem/ibm/libpldmresponder/file_io_by_type.cpp
+++ b/oem/ibm/libpldmresponder/file_io_by_type.cpp
@@ -2,9 +2,6 @@
#include "file_io_by_type.hpp"
-#include "libpldm/base.h"
-#include "libpldm/file_io.h"
-
#include "common/utils.hpp"
#include "file_io_type_cert.hpp"
#include "file_io_type_dump.hpp"
@@ -13,6 +10,8 @@
#include "file_io_type_progress_src.hpp"
#include "xyz/openbmc_project/Common/error.hpp"
+#include <libpldm/base.h>
+#include <libpldm/file_io.h>
#include <stdint.h>
#include <unistd.h>
diff --git a/oem/ibm/libpldmresponder/file_io_type_cert.cpp b/oem/ibm/libpldmresponder/file_io_type_cert.cpp
index 5f0d220..d396abe 100644
--- a/oem/ibm/libpldmresponder/file_io_type_cert.cpp
+++ b/oem/ibm/libpldmresponder/file_io_type_cert.cpp
@@ -1,10 +1,9 @@
#include "file_io_type_cert.hpp"
-#include "libpldm/base.h"
-#include "libpldm/file_io.h"
-
#include "common/utils.hpp"
+#include <libpldm/base.h>
+#include <libpldm/file_io.h>
#include <stdint.h>
#include <iostream>
diff --git a/oem/ibm/libpldmresponder/file_io_type_dump.cpp b/oem/ibm/libpldmresponder/file_io_type_dump.cpp
index 87eaa22..708dd87 100644
--- a/oem/ibm/libpldmresponder/file_io_type_dump.cpp
+++ b/oem/ibm/libpldmresponder/file_io_type_dump.cpp
@@ -1,12 +1,11 @@
#include "file_io_type_dump.hpp"
-#include "libpldm/base.h"
-#include "libpldm/file_io.h"
-
#include "common/utils.hpp"
#include "utils.hpp"
#include "xyz/openbmc_project/Common/error.hpp"
+#include <libpldm/base.h>
+#include <libpldm/file_io.h>
#include <stdint.h>
#include <systemd/sd-bus.h>
#include <unistd.h>
diff --git a/oem/ibm/libpldmresponder/file_io_type_pel.cpp b/oem/ibm/libpldmresponder/file_io_type_pel.cpp
index 022b75e..8374abf 100644
--- a/oem/ibm/libpldmresponder/file_io_type_pel.cpp
+++ b/oem/ibm/libpldmresponder/file_io_type_pel.cpp
@@ -2,12 +2,11 @@
#include "file_io_type_pel.hpp"
-#include "libpldm/base.h"
-#include "libpldm/file_io.h"
-
#include "common/utils.hpp"
#include "xyz/openbmc_project/Common/error.hpp"
+#include <libpldm/base.h>
+#include <libpldm/file_io.h>
#include <stdint.h>
#include <systemd/sd-bus.h>
#include <unistd.h>
diff --git a/oem/ibm/libpldmresponder/file_table.cpp b/oem/ibm/libpldmresponder/file_table.cpp
index 48388ee..594adc7 100644
--- a/oem/ibm/libpldmresponder/file_table.cpp
+++ b/oem/ibm/libpldmresponder/file_table.cpp
@@ -1,6 +1,6 @@
#include "file_table.hpp"
-#include "libpldm/utils.h"
+#include <libpldm/utils.h>
#include <fstream>
#include <iostream>
diff --git a/oem/ibm/libpldmresponder/file_table.hpp b/oem/ibm/libpldmresponder/file_table.hpp
index 3354e89..502e714 100644
--- a/oem/ibm/libpldmresponder/file_table.hpp
+++ b/oem/ibm/libpldmresponder/file_table.hpp
@@ -1,7 +1,6 @@
#pragma once
-#include "libpldm/pldm_types.h"
-
+#include <libpldm/pldm_types.h>
#include <stdint.h>
#include <nlohmann/json.hpp>
diff --git a/oem/ibm/libpldmresponder/inband_code_update.cpp b/oem/ibm/libpldmresponder/inband_code_update.cpp
index 9a02c13..3066b40 100644
--- a/oem/ibm/libpldmresponder/inband_code_update.cpp
+++ b/oem/ibm/libpldmresponder/inband_code_update.cpp
@@ -1,12 +1,11 @@
#include "inband_code_update.hpp"
-#include "libpldm/entity.h"
-
#include "libpldmresponder/pdr.hpp"
#include "oem_ibm_handler.hpp"
#include "xyz/openbmc_project/Common/error.hpp"
#include <arpa/inet.h>
+#include <libpldm/entity.h>
#include <sdbusplus/server.hpp>
#include <xyz/openbmc_project/Dump/NewDump/server.hpp>
diff --git a/oem/ibm/libpldmresponder/oem_ibm_handler.cpp b/oem/ibm/libpldmresponder/oem_ibm_handler.cpp
index abe9e69..6e77e99 100644
--- a/oem/ibm/libpldmresponder/oem_ibm_handler.cpp
+++ b/oem/ibm/libpldmresponder/oem_ibm_handler.cpp
@@ -1,13 +1,12 @@
#include "oem_ibm_handler.hpp"
-#include "libpldm/entity.h"
-#include "libpldm/pldm.h"
-
#include "file_io_type_lid.hpp"
#include "libpldmresponder/file_io.hpp"
#include "libpldmresponder/pdr_utils.hpp"
+#include <libpldm/entity.h>
#include <libpldm/entity_oem_ibm.h>
+#include <libpldm/pldm.h>
using namespace pldm::pdr;
using namespace pldm::utils;
diff --git a/oem/ibm/libpldmresponder/oem_ibm_handler.hpp b/oem/ibm/libpldmresponder/oem_ibm_handler.hpp
index b5f4032..7dbd8d8 100644
--- a/oem/ibm/libpldmresponder/oem_ibm_handler.hpp
+++ b/oem/ibm/libpldmresponder/oem_ibm_handler.hpp
@@ -1,7 +1,4 @@
#pragma once
-#include "libpldm/entity.h"
-#include "libpldm/platform.h"
-#include "libpldm/state_set_oem_ibm.h"
#include "inband_code_update.hpp"
#include "libpldmresponder/oem_handler.hpp"
@@ -9,6 +6,10 @@
#include "libpldmresponder/platform.hpp"
#include "requester/handler.hpp"
+#include <libpldm/entity.h>
+#include <libpldm/platform.h>
+#include <libpldm/state_set_oem_ibm.h>
+
typedef ibm_oem_pldm_state_set_firmware_update_state_values CodeUpdateState;
namespace pldm
diff --git a/oem/ibm/libpldmresponder/platform_oem_ibm.cpp b/oem/ibm/libpldmresponder/platform_oem_ibm.cpp
index 3f090a9..690d65f 100644
--- a/oem/ibm/libpldmresponder/platform_oem_ibm.cpp
+++ b/oem/ibm/libpldmresponder/platform_oem_ibm.cpp
@@ -1,11 +1,11 @@
#include "platform_oem_ibm.hpp"
-#include "libpldm/platform_oem_ibm.h"
-#include "libpldm/pldm.h"
-
#include "common/utils.hpp"
#include "libpldmresponder/pdr.hpp"
+#include <libpldm/platform_oem_ibm.h>
+#include <libpldm/pldm.h>
+
#include <xyz/openbmc_project/Common/error.hpp>
#include <iostream>
diff --git a/oem/ibm/libpldmresponder/utils.cpp b/oem/ibm/libpldmresponder/utils.cpp
index 7b0bd09..15987ff 100644
--- a/oem/ibm/libpldmresponder/utils.cpp
+++ b/oem/ibm/libpldmresponder/utils.cpp
@@ -1,7 +1,6 @@
#include "utils.hpp"
-#include "libpldm/base.h"
-
+#include <libpldm/base.h>
#include <sys/socket.h>
#include <sys/types.h>
#include <sys/un.h>
diff --git a/oem/ibm/requester/dbus_to_file_handler.cpp b/oem/ibm/requester/dbus_to_file_handler.cpp
index 3f031bc..48157bd 100644
--- a/oem/ibm/requester/dbus_to_file_handler.cpp
+++ b/oem/ibm/requester/dbus_to_file_handler.cpp
@@ -1,10 +1,10 @@
#include "dbus_to_file_handler.hpp"
-#include "libpldm/file_io.h"
-#include "libpldm/pldm.h"
-
#include "common/utils.hpp"
+#include <libpldm/file_io.h>
+#include <libpldm/pldm.h>
+
namespace pldm
{
namespace requester
diff --git a/oem/ibm/requester/dbus_to_file_handler.hpp b/oem/ibm/requester/dbus_to_file_handler.hpp
index 0fbec1c..60f1b70 100644
--- a/oem/ibm/requester/dbus_to_file_handler.hpp
+++ b/oem/ibm/requester/dbus_to_file_handler.hpp
@@ -1,10 +1,10 @@
#pragma once
-#include "libpldm/platform.h"
-
#include "pldmd/dbus_impl_requester.hpp"
#include "requester/handler.hpp"
+#include <libpldm/platform.h>
+
#include <filesystem>
#include <fstream>
#include <map>
diff --git a/oem/ibm/test/libpldmresponder_fileio_test.cpp b/oem/ibm/test/libpldmresponder_fileio_test.cpp
index 1d83ee0..884b375 100644
--- a/oem/ibm/test/libpldmresponder_fileio_test.cpp
+++ b/oem/ibm/test/libpldmresponder_fileio_test.cpp
@@ -1,5 +1,3 @@
-#include "libpldm/base.h"
-#include "libpldm/file_io.h"
#include "libpldmresponder/file_io.hpp"
#include "libpldmresponder/file_io_by_type.hpp"
@@ -10,6 +8,9 @@
#include "libpldmresponder/file_table.hpp"
#include "xyz/openbmc_project/Common/error.hpp"
+#include <libpldm/base.h>
+#include <libpldm/file_io.h>
+
#include <nlohmann/json.hpp>
#include <filesystem>
diff --git a/oem/ibm/test/libpldmresponder_oem_platform_test.cpp b/oem/ibm/test/libpldmresponder_oem_platform_test.cpp
index 614a09b..592a591 100644
--- a/oem/ibm/test/libpldmresponder_oem_platform_test.cpp
+++ b/oem/ibm/test/libpldmresponder_oem_platform_test.cpp
@@ -1,5 +1,3 @@
-#include "libpldm/entity.h"
-
#include "common/test/mocked_utils.hpp"
#include "common/utils.hpp"
#include "libpldmresponder/event_parser.hpp"
@@ -9,6 +7,7 @@
#include "oem/ibm/libpldmresponder/inband_code_update.hpp"
#include "oem/ibm/libpldmresponder/oem_ibm_handler.hpp"
+#include <libpldm/entity.h>
#include <libpldm/entity_oem_ibm.h>
#include <sdeventplus/event.hpp>