commit c80f3efa2213d30698be59c88d07cd7016d90ba2
author Brad Bishop <bradleyb@fuzziesquirrel.com> Thu Oct 07 16:34:13 2021 -0400
committer Brad Bishop <bradleyb@fuzziesquirrel.com> Mon Oct 18 13:10:22 2021 +0000
tree e36a596900728e27eb4f1ef71bb6c1ba68fb212c
parent fc0d14dfbd52524826864c0540c5a0fb95f0ca29

pldmd: make invalid cmdline arguments cause exit

These invalid invocations will print the usage message but the program
will run anyway:
  pldmd -v 2
  pldmd -z

Running pldmd with no arguments is supported and valid but the usage
message is shown.

The expected behavior when an application is invoked with invalid
arguments is that the program will exit.  The expected behavior when an
application is invoked with valid arguments is that it will not print
any error messages.  Fix the argument parsing code so it matches
expectations.

Change-Id: Iaa38fd0bfb1d1597ff44996f88e8cc0081df306a
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

pldmd/pldmd.cpp

diff --git a/pldmd/pldmd.cpp b/pldmd/pldmd.cpp
index 38ee7cd..f009e88 100644
--- a/pldmd/pldmd.cpp
+++ b/pldmd/pldmd.cpp
@@ -147,12 +147,13 @@
                     break;
                 default:
                     optionUsage();
-                    break;
+                    exit(EXIT_FAILURE);
             }
             break;
-        default:
-            optionUsage();
+        case -1:
             break;
+        default:
+            exit(EXIT_FAILURE);
     }
 
     /* Create local socket. */